From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757287AbcDEHiI (ORCPT ); Tue, 5 Apr 2016 03:38:08 -0400 Received: from mail-pf0-f179.google.com ([209.85.192.179]:36686 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753633AbcDEHiG (ORCPT ); Tue, 5 Apr 2016 03:38:06 -0400 Date: Tue, 5 Apr 2016 16:39:32 +0900 From: Sergey Senozhatsky To: Sergey Senozhatsky Cc: Andrew Morton , Sergey Senozhatsky , Jan Kara , Petr Mladek , Tejun Heo , Tetsuo Handa , linux-kernel@vger.kernel.org, Byungchul Park , Jan Kara Subject: Re: [PATCH v10 1/2] printk: Make printk() completely async Message-ID: <20160405073932.GA513@swordfish> References: <1459789048-1337-1-git-send-email-sergey.senozhatsky@gmail.com> <1459789048-1337-2-git-send-email-sergey.senozhatsky@gmail.com> <20160404155149.a3e3307def2d1315e2099c63@linux-foundation.org> <20160405051717.GB1954@swordfish> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160405051717.GB1954@swordfish> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (04/05/16 14:17), Sergey Senozhatsky wrote: [..] > > Could do with a comment explaining why late_initcall was chosen. > > late_initcall was chosen because of workqueue early_initcall, and > I just decided not to change it when I switched from wq to a > dedicated printk kthread. late_initcall seemed to be OK. can do > init_printk_kthread() somewhere in init/main start_kernel(). or rather move it a bit earlier. core_init sounds appropriate; or postcore. don't want to export yet another printk symbol. -ss