From: Herbert Xu <herbert@gondor.apana.org.au>
To: Tadeusz Struk <tadeusz.struk@intel.com>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net
Subject: Re: [PATCH 0/3] crypto: af_alg - add TLS type encryption
Date: Tue, 5 Apr 2016 19:29:40 +0800 [thread overview]
Message-ID: <20160405112940.GB11852@gondor.apana.org.au> (raw)
In-Reply-To: <20160306012044.6369.63924.stgit@tstruk-mobl1>
On Sat, Mar 05, 2016 at 05:20:44PM -0800, Tadeusz Struk wrote:
> Hi,
> The following series adds TLS type authentication. To do this a new
> template, encauth, is introduced. It is derived from the existing authenc
> template and modified to work in "first auth then encrypt" mode.
> The algif interface is also changed to work with the new authentication type.
What is the point of this patch-set? Who is going to be the user?
Also you're including padding into the algorithm. That goes against
the way we implemented IPsec. What is the justification for doing
it in the crypto layer instead of the protocol layer?
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2016-04-05 11:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-06 1:20 [PATCH 0/3] crypto: af_alg - add TLS type encryption Tadeusz Struk
2016-03-06 1:20 ` [PATCH 1/3] crypto: authenc " Tadeusz Struk
2016-03-07 9:05 ` Cristian Stoica
2016-03-07 14:31 ` Tadeusz Struk
2016-03-08 8:20 ` Cristian Stoica
2016-03-08 16:49 ` Tadeusz Struk
2016-03-06 1:20 ` [PATCH 2/3] crypto: af_alg - add AEAD operation type Tadeusz Struk
2016-03-06 1:21 ` [PATCH 3/3] crypto: algif_aead - modify algif aead interface to work with encauth Tadeusz Struk
2016-04-05 11:29 ` Herbert Xu [this message]
2016-04-06 17:56 ` [PATCH 0/3] crypto: af_alg - add TLS type encryption Tadeusz Struk
2016-04-08 2:52 ` Herbert Xu
2016-04-08 2:58 ` Tom Herbert
2016-04-12 11:13 ` Fridolin Pokorny
2016-04-13 22:46 ` Tadeusz Struk
2016-04-14 6:47 ` Nikos Mavrogiannopoulos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160405112940.GB11852@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tadeusz.struk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).