From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755183AbcDGGrG (ORCPT ); Thu, 7 Apr 2016 02:47:06 -0400 Received: from e23smtp01.au.ibm.com ([202.81.31.143]:43262 "EHLO e23smtp01.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751780AbcDGGrF (ORCPT ); Thu, 7 Apr 2016 02:47:05 -0400 X-IBM-Helo: d23dlp02.au.ibm.com X-IBM-MailFrom: naveen.n.rao@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Date: Thu, 7 Apr 2016 12:02:34 +0530 From: "Naveen N. Rao" To: Ananth N Mavinakayanahalli Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Thiago Jung Bauermann , Arnaldo Carvalho de Melo , Masami Hiramatsu , Mark Wielaard Subject: Re: [PATCH 1/2] perf/powerpc: Fix kprobe and kretprobe handling with kallsyms Message-ID: <20160407063233.GJ15993@naverao1-tp.in.ibm.com> References: <97bd954477bc7a94e676d3510c6f945ff9c9e0cc.1459942081.git.naveen.n.rao@linux.vnet.ibm.com> <20160407043019.GD3620@in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160407043019.GD3620@in.ibm.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16040706-1618-0000-0000-0000454EC965 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/04/07 10:00AM, Ananth N wrote: > On Wed, Apr 06, 2016 at 06:02:57PM +0530, Naveen N. Rao wrote: > > > + if (!pev->uprobes && map->dso->symtab_type == DSO_BINARY_TYPE__KALLSYMS) > > tev->point.offset += PPC64LE_LEP_OFFSET; > > uprobes check against kallsysms? Am I missing something here? Ah yes. That check shouldn't be necessary since symtab_type would be different anyway. I will remove that check. Thanks for the review! - Naveen