From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754902AbcDGG6Z (ORCPT ); Thu, 7 Apr 2016 02:58:25 -0400 Received: from mx2.suse.de ([195.135.220.15]:48872 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750839AbcDGG6V (ORCPT ); Thu, 7 Apr 2016 02:58:21 -0400 Date: Wed, 6 Apr 2016 23:58:07 -0700 From: Davidlohr Bueso To: Michal Hocko Cc: LKML , Peter Zijlstra , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , "David S. Miller" , Tony Luck , Andrew Morton , Chris Zankel , Max Filippov , x86@kernel.org, linux-alpha@vger.kernel.org, linux-ia64@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-arch@vger.kernel.org Subject: Re: [PATCH 03/11] locking, rwsem: introduce basis for down_write_killable Message-ID: <20160407065807.GA29020@linux-uzut.site> References: <1459508695-14915-1-git-send-email-mhocko@kernel.org> <1459508695-14915-4-git-send-email-mhocko@kernel.org> <20160402044125.GC5329@linux-uzut.site> <20160404091659.GA13463@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20160404091659.GA13463@dhcp22.suse.cz> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 04 Apr 2016, Michal Hocko wrote: >Not sure I got your point here. You set current to TASK_KILLABLE in the sleep loop, why do you want to change it here to TASK_RUNNING if its about to be killed? At least in the case of UNINTERRUPTABLE we do it merely as a redundancy after the breaking out of the loop. Of course we also acquired the lock in the first place by that time and we _better_ be running. Thanks, Davidlohr