From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Sangbeom Kim <sbkim73@samsung.com>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 1/2] regulator: s2mps11: Use module_platform_driver() instead subsys initcall
Date: Thu, 7 Apr 2016 21:30:24 +0900 [thread overview]
Message-ID: <20160407123024.GA6765@kozik-lap> (raw)
In-Reply-To: <1459950587-8807-1-git-send-email-javier@osg.samsung.com>
On Wed, Apr 06, 2016 at 09:49:46AM -0400, Javier Martinez Canillas wrote:
> The driver's init and exit function don't do anything besides registering
> and unregistering the platform driver, so the module_platform_driver()
> macro could just be used instead of having separate functions.
>
> Currently the macro is not being used because the driver is initialized at
> subsys init call level but this isn't necessary since consumer devices are
> defined in the DT as dependencies so there's no need for init calls order.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
> This patch was tested on an Exynos5422 Odroid XU4 board.
This test might not be sufficient. XU4 is not a mobile device like many
other users of this driver (except Arndale Octa and Artiks all of other
users are mobiles/wearables).
For example XU4 does not have USB OTG (like other devices and like XU3).
Best regards,
Krzysztof
>
> drivers/regulator/s2mps11.c | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
next prev parent reply other threads:[~2016-04-07 12:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 13:49 [PATCH 1/2] regulator: s2mps11: Use module_platform_driver() instead subsys initcall Javier Martinez Canillas
2016-04-06 13:49 ` [PATCH 2/2] regulator: max77686: " Javier Martinez Canillas
2016-04-07 12:30 ` Krzysztof Kozlowski [this message]
2016-04-07 18:16 ` [PATCH 1/2] regulator: s2mps11: " Javier Martinez Canillas
2016-04-08 3:55 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160407123024.GA6765@kozik-lap \
--to=k.kozlowski@samsung.com \
--cc=broonie@kernel.org \
--cc=javier@osg.samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).