From: Rob Herring <robh@kernel.org>
To: Jisheng Zhang <jszhang@marvell.com>
Cc: wsa@the-dreams.de, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com,
mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] i2c: designware-platdrv: get fast/std speed scl high/low count from DT
Date: Thu, 7 Apr 2016 12:57:59 -0500 [thread overview]
Message-ID: <20160407175759.GO32257@rob-hp-laptop> (raw)
In-Reply-To: <1459927680-5480-1-git-send-email-jszhang@marvell.com>
On Wed, Apr 06, 2016 at 03:28:00PM +0800, Jisheng Zhang wrote:
> Sometimes, it's convenient to define the scl's high/low count directly,
> e.g HW people would do some measurement then directly give out the
> optimum counts. Previously, we solved the sda falling time and scl
> falling time by i2c_dw_scl_hcnt() and i2c_dw_scl_lcnt(), then put them
> into dt, but what we really care isn't the sda/scl falling time.
This is just so you can put specific clock count instead of converting
from nanoseconds with standard properties or you gain some additional
control of the timing. If only the former, then I prefer we stick with
the common properties.
> From another side, the dw_i2c_acpi_configure() on ACPI platform also
> get hcnt/lcnt values rather than the sda/scl falling time from ACPI
> method, we want similar feature for DT platforms.
That's nice, but not really a reason IMO.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
> Documentation/devicetree/bindings/i2c/i2c-designware.txt | 16 ++++++++++++++++
> drivers/i2c/busses/i2c-designware-platdrv.c | 8 ++++++++
> 2 files changed, 24 insertions(+)
next prev parent reply other threads:[~2016-04-07 18:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 7:28 [PATCH] i2c: designware-platdrv: get fast/std speed scl high/low count from DT Jisheng Zhang
2016-04-07 17:57 ` Rob Herring [this message]
2016-04-13 12:11 ` Jisheng Zhang
2016-04-24 20:39 ` Wolfram Sang
2016-04-07 18:05 ` Andy Shevchenko
2016-04-13 12:16 ` Jisheng Zhang
2016-04-13 13:23 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160407175759.GO32257@rob-hp-laptop \
--to=robh@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jarkko.nikula@linux.intel.com \
--cc=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=pawel.moll@arm.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).