From: joeyli <jlee@suse.com>
To: Benjamin Poirier <bpoirier@suse.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Michal Marek <mmarek@suse.cz>,
"Yann E . MORIN " <yann.morin.1998@free.fr>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] localmodconfig: Fix parsing of Kconfig "source" statements
Date: Fri, 8 Apr 2016 22:59:02 +0800 [thread overview]
Message-ID: <20160408145902.GH29941@linux-rxt1.site> (raw)
In-Reply-To: <1459619722-13695-1-git-send-email-bpoirier@suse.com>
On Sat, Apr 02, 2016 at 10:55:21AM -0700, Benjamin Poirier wrote:
> The parameter of Kconfig "source" statements does not need to be quoted.
> The current regex causes many kconfig files to be skipped and hence,
> dependencies to be missed.
>
> Also fix the whitespace repeat count.
>
> Signed-off-by: Benjamin Poirier <bpoirier@suse.com>
Tested-by: Lee, Chun-Yi <jlee@suse.com>
> ---
> scripts/kconfig/streamline_config.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/streamline_config.pl b/scripts/kconfig/streamline_config.pl
> index f3d3fb4..7036ae3 100755
> --- a/scripts/kconfig/streamline_config.pl
> +++ b/scripts/kconfig/streamline_config.pl
> @@ -188,7 +188,7 @@ sub read_kconfig {
> $cont = 0;
>
> # collect any Kconfig sources
> - if (/^source\s*"(.*)"/) {
> + if (/^source\s+"?([^"]+)/) {
> my $kconfig = $1;
> # prevent reading twice.
> if (!defined($read_kconfigs{$kconfig})) {
> --
> 2.7.2
Regards
Joey Lee
next prev parent reply other threads:[~2016-04-08 14:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-02 17:55 [PATCH 1/2] localmodconfig: Fix parsing of Kconfig "source" statements Benjamin Poirier
2016-04-02 17:55 ` [PATCH 2/2] localmodconfig: Reset certificate paths Benjamin Poirier
2016-04-08 14:59 ` joeyli
2016-04-26 14:02 ` Steven Rostedt
2016-04-26 18:51 ` Benjamin Poirier
2016-04-26 18:52 ` [PATCH v2] " Benjamin Poirier
2016-04-26 19:48 ` Steven Rostedt
2016-04-08 14:59 ` joeyli [this message]
2016-04-26 14:03 ` [PATCH 1/2] localmodconfig: Fix parsing of Kconfig "source" statements Steven Rostedt
2016-04-08 18:29 ` Steven Rostedt
2016-04-10 23:52 ` Benjamin Poirier
2016-04-11 0:06 ` [PATCH 1/4] localmodconfig: Recognize more keywords that end a menu entry Benjamin Poirier
2016-04-11 0:06 ` [PATCH 2/4] localmodconfig: Fix parsing of "help" text Benjamin Poirier
2016-04-11 0:06 ` [PATCH 3/4] localmodconfig: Add missing $ to reference a variable Benjamin Poirier
2016-04-11 0:06 ` [PATCH 4/4] localmodconfig: Recognize standalone "prompt" Benjamin Poirier
2016-04-26 15:11 ` Steven Rostedt
2016-04-26 18:54 ` Benjamin Poirier
2016-04-26 18:56 ` [PATCH v2] localmodconfig: Fix whitespace repeat count after "tristate" Benjamin Poirier
2016-04-26 19:51 ` Steven Rostedt
2016-04-26 21:35 ` Benjamin Poirier
2016-04-26 22:34 ` Steven Rostedt
2016-04-18 20:29 ` [PATCH 1/2] localmodconfig: Fix parsing of Kconfig "source" statements Benjamin Poirier
2016-04-18 21:43 ` Steven Rostedt
2016-04-18 23:49 ` Benjamin Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160408145902.GH29941@linux-rxt1.site \
--to=jlee@suse.com \
--cc=bpoirier@suse.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=rostedt@goodmis.org \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).