Re: [PATCH v8 0/5] Add Support for Hi6220 PMIC Hi6553 MFD Core

From: Lee Jones <lee.jones@linaro.org>
To: Chen Feng <puck.chen@hisilicon.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org,
	linux-kernel@vger.kernel.org, w.f@huawei.com,
	kong.kongxinwei@hisilicon.com, haojian.zhuang@linaro.org,
	suzhuangluan@hisilicon.com, dan.zhao@hisilicon.com
Subject: Re: [PATCH v8 0/5] Add Support for Hi6220 PMIC Hi6553 MFD Core
Date: Mon, 11 Apr 2016 09:14:46 +0100	[thread overview]
Message-ID: <20160411081446.GC4592@x1> (raw)
In-Reply-To: <1455431363-113771-1-git-send-email-puck.chen@hisilicon.com>

On Sun, 14 Feb 2016, Chen Feng wrote:

> The patch sets add support for Hi6220 PMIC Hi655x MFD core and its
> regulator driver.
> Current testing and support board is Hikey which is one of 96boards.
> It is an arm64 open source board. For more information about this board,
> please access https://www.96boards.org.
> 
> This is hardware layout for access PMIC Hi655x from AP SoC Hi6220.
> Between PMIC Hi655x and Hi6220, the physical signal channel is SSI.
> We can use memory-mapped I/O to communicate.
> 
> +----------------+             +-------------+
> |                |             |             |
> |    Hi6220      |   SSI bus   |   Hi655x    |
> |                |-------------|             |
> |                |(REGMAP_MMIO)|             |
> +----------------+             +-------------+
> 
> V2: Code refactoring of regulator.
> 
> V3: Drop mtcmos from this patch and use regmap-irq.
> 
> V4: Move the vset-table to driver code and donot open code for it.
> 
> V5: Use regulators_node and of_match, donot open code fot it.
> 
> V7: Change the constraints into hikey.dts and fix code in PMIC.
> 
> V8: Change format in document, and fix bit mask in regulator.
> 
> Chen Feng (5):
>   mfd: hi655x: Add document for mfd hi665x PMIC
>   regulator: hi655x: Document for hi655x regulator
>   mfd: hi655x: Add MFD driver for hi655x
>   regulator: hi655x: enable regulator for hi655x PMIC
>   arm64: dts: hisilicon: Add hi655x pmic dts node

So what's going on with this set?  Can the MFD patches go in via my
tree on their own?  Or are there dependencies between them and the
Regulator changes?  If the latter, then we need Mark's Ack to
proceed.

>  .../devicetree/bindings/mfd/hisilicon,hi655x.txt   |  27 +++
>  .../regulator/hisilicon,hi655x-regulator.txt       |  29 +++
>  arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts     |  87 ++++++++
>  drivers/mfd/Kconfig                                |  10 +
>  drivers/mfd/Makefile                               |   1 +
>  drivers/mfd/hi655x-pmic.c                          | 162 +++++++++++++++
>  drivers/regulator/Kconfig                          |   8 +
>  drivers/regulator/Makefile                         |   1 +
>  drivers/regulator/hi655x-regulator.c               | 227 +++++++++++++++++++++
>  include/linux/mfd/hi655x-pmic.h                    |  55 +++++
>  10 files changed, 607 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt
>  create mode 100644 Documentation/devicetree/bindings/regulator/hisilicon,hi655x-regulator.txt
>  create mode 100644 drivers/mfd/hi655x-pmic.c
>  create mode 100644 drivers/regulator/hi655x-regulator.c
>  create mode 100644 include/linux/mfd/hi655x-pmic.h
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog