From: Lee Jones <lee.jones@linaro.org>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Andi Shyti <andi.shyti@samsung.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Laxman Dewangan <ldewangan@nvidia.com>
Subject: Re: [RESEND PATCH] mfd: max77686: Use module_i2c_driver() instead of subsys initcall
Date: Mon, 11 Apr 2016 12:51:47 +0100 [thread overview]
Message-ID: <20160411115147.GU8094@x1> (raw)
In-Reply-To: <1459809962-8883-1-git-send-email-javier@osg.samsung.com>
On Mon, 04 Apr 2016, Javier Martinez Canillas wrote:
> The driver's init and exit function don't do anything besides adding and
> deleting the I2C driver so the module_i2c_driver() macro could be used.
>
> Currently is not being used because the driver is initialized at subsys
> initcall level, claiming that this is done to allow consumers devices to
> use the resources provided by this driver. But dependencies are in DT so
> manual ordering of init calls is not necessary any more.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> Changes in the resend:
> - Change commit message to make clear that dependencies are in DT instead
> giving the impression that it was wishful thinking (Krzysztof Kozlowski).
>
> Hello,
>
> This patch was first sent as a part of a bigger series to allow the
> max77686 MFD driver to be built as a module [0]. The other patches
> were already picked but $SUBJECT wasn't, probably because there was
> a dependency with a patch on the exynos thermal driver [1].
>
> But the exynos thermal patches also landed in mainline so I think it
> should be safe to merged $SUBJECT now.
>
> [0]: https://lkml.org/lkml/2016/2/11/857
> [1]: https://lkml.org/lkml/2016/2/18/592
>
> Best regards,
> Javier
>
> drivers/mfd/max77686.c | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c
> index c1aff46e89d9..66cc9bebb7ba 100644
> --- a/drivers/mfd/max77686.c
> +++ b/drivers/mfd/max77686.c
> @@ -321,18 +321,7 @@ static struct i2c_driver max77686_i2c_driver = {
> .id_table = max77686_i2c_id,
> };
>
> -static int __init max77686_i2c_init(void)
> -{
> - return i2c_add_driver(&max77686_i2c_driver);
> -}
> -/* init early so consumer devices can complete system boot */
> -subsys_initcall(max77686_i2c_init);
> -
> -static void __exit max77686_i2c_exit(void)
> -{
> - i2c_del_driver(&max77686_i2c_driver);
> -}
> -module_exit(max77686_i2c_exit);
> +module_i2c_driver(max77686_i2c_driver);
>
> MODULE_DESCRIPTION("MAXIM 77686/802 multi-function core driver");
> MODULE_AUTHOR("Chiwoong Byun <woong.byun@samsung.com>");
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2016-04-11 11:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 22:46 [RESEND PATCH] mfd: max77686: Use module_i2c_driver() instead of subsys initcall Javier Martinez Canillas
2016-04-05 1:47 ` Krzysztof Kozlowski
2016-04-05 1:57 ` Andi Shyti
2016-04-11 11:51 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160411115147.GU8094@x1 \
--to=lee.jones@linaro.org \
--cc=andi.shyti@samsung.com \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).