From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754471AbcDKSvV (ORCPT ); Mon, 11 Apr 2016 14:51:21 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:53326 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753398AbcDKSvT (ORCPT ); Mon, 11 Apr 2016 14:51:19 -0400 Date: Mon, 11 Apr 2016 20:51:15 +0200 From: Andrew Lunn To: Sergei Shtylyov Cc: nicolas.ferre@atmel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH RFT 2/2] macb: kill PHY reset code Message-ID: <20160411185115.GA30623@lunn.ch> References: <81129033.NXiOLTg1so@wasted.cogentembedded.com> <2811962.eGX2i5RJbZ@wasted.cogentembedded.com> <20160411022802.GB4307@lunn.ch> <570BE1C5.70502@cogentembedded.com> <20160411181904.GB29709@lunn.ch> <570BEF46.7060105@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <570BEF46.7060105@cogentembedded.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 11, 2016 at 09:39:02PM +0300, Sergei Shtylyov wrote: > Hello. > > On 04/11/2016 09:19 PM, Andrew Lunn wrote: > > >>>The code you are deleting would of ignored the flags in the gpio > >>>property, i.e. active low. > >> > >> Hm, you're right -- I forgot about that... :-/ > >> > >>>The new code in the previous patch does > >>>however take the flags into account. Did you check if there are any > >>>device trees which have flags, which were never used, but are now > >>>going to be used and thus break... > >> > >> Checked this now and found out arch/arm/boot/dts/ar91-vinco.dts. > >>Looks like it needs to be fixed indeed... > >> > >And this is where it gets tricky. You are breaking backwards > >compatibility by now respecting the flag. An old DT blob is not going > >to work. > > Do we care that much about the DT blobs that are just *wrong*? Wrong, but currently works. > >You potentially need to add a new property and deprecate the old one. > > I would like to avoid that... You will need the agreement from the at91-vinco maintainer. Andrew