From: Mark Brown <broonie@kernel.org>
To: P L Sai Krishna <lakshmi.sai.krishna.potthuri@xilinx.com>
Cc: "Michal Simek" <michal.simek@xilinx.com>,
"Soren Brinkmann" <soren.brinkmann@xilinx.com>,
"David Woodhouse" <dwmw2@infradead.org>,
"Brian Norris" <computersforpeace@gmail.com>,
"Javier Martinez Canillas" <javier@osg.samsung.com>,
"Boris Brezillon" <boris.brezillon@free-electrons.com>,
"Stephen Warren" <swarren@nvidia.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Andrew F. Davis" <afd@ti.com>, "Marek Vasut" <marex@denx.de>,
"Jagan Teki" <jteki@openedev.com>,
"Rafał Miłecki" <zajec5@gmail.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Harini Katakam" <harinik@xilinx.com>,
"Punnaiah Choudary Kalluri" <punnaia@xilinx.com>,
"Anirudha Sarangi" <anirudh@xilinx.com>,
"P L Sai Krishna" <lakshmis@xilinx.com>
Subject: Re: [LINUX PATCH v2 1/3] spi: Added dummy_cycle entry in the spi_transfer structure.
Date: Tue, 12 Apr 2016 07:10:07 +0100 [thread overview]
Message-ID: <20160412061007.GY3351@sirena.org.uk> (raw)
In-Reply-To: <1460039969-9835-1-git-send-email-lakshmis@xilinx.com>
[-- Attachment #1: Type: text/plain, Size: 478 bytes --]
On Thu, Apr 07, 2016 at 08:09:27PM +0530, P L Sai Krishna wrote:
> + * @dummy_cycles: number of dummy cycles. If host controller requires
> + * dummy cycles rather than dummy bytes which send along with Cmd
> + * and address then this dummy_cycles is used.
I'm having a very hard time parsing this, partly because it is entirely
flash specific (the whole concept of cmd and address is missing from
SPI). As Cyrille said perhaps this should go in a flash specific
interface?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2016-04-12 6:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 14:39 [LINUX PATCH v2 1/3] spi: Added dummy_cycle entry in the spi_transfer structure P L Sai Krishna
2016-04-07 14:39 ` [LINUX PATCH v2 2/3] mtd:m25p80: Assigned number of dummy cycles to dummy_cycles P L Sai Krishna
2016-04-07 14:59 ` kbuild test robot
2016-04-07 14:39 ` [LINUX PATCH v2 3/3] spi:zynqmp:gqspi: Added separate dummy entry P L Sai Krishna
2016-04-07 15:02 ` [LINUX PATCH v2 1/3] spi: Added dummy_cycle entry in the spi_transfer structure Cyrille Pitchen
2016-04-13 5:21 ` Lakshmi Sai Krishna Potthuri
2016-04-14 8:06 ` Cyrille Pitchen
2016-04-14 8:57 ` Mark Brown
2016-04-14 15:23 ` Cyrille Pitchen
2016-04-12 6:10 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160412061007.GY3351@sirena.org.uk \
--to=broonie@kernel.org \
--cc=afd@ti.com \
--cc=anirudh@xilinx.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=geert+renesas@glider.be \
--cc=harinik@xilinx.com \
--cc=javier@osg.samsung.com \
--cc=jteki@openedev.com \
--cc=lakshmi.sai.krishna.potthuri@xilinx.com \
--cc=lakshmis@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=marex@denx.de \
--cc=michal.simek@xilinx.com \
--cc=punnaia@xilinx.com \
--cc=soren.brinkmann@xilinx.com \
--cc=swarren@nvidia.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).