From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965354AbcDMHwn (ORCPT ); Wed, 13 Apr 2016 03:52:43 -0400 Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:51563 "EHLO e06smtp11.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932996AbcDMHwl (ORCPT ); Wed, 13 Apr 2016 03:52:41 -0400 X-IBM-Helo: d06dlp03.portsmouth.uk.ibm.com X-IBM-MailFrom: heiko.carstens@de.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org;linux-next@vger.kernel.org;linux-s390@vger.kernel.org Date: Wed, 13 Apr 2016 09:52:35 +0200 From: Heiko Carstens To: Martin Schwidefsky Cc: Sudip Mukherjee , Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org Subject: Re: linux-next: Tree for Apr 4 Message-ID: <20160413075235.GB3832@osiris> References: <20160404140951.148c95f6@canb.auug.org.au> <57025C35.6090206@gmail.com> <20160404142635.GF4058@osiris> <20160412183408.248092c7@mschwide> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160412183408.248092c7@mschwide> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16041307-0041-0000-0000-000012813549 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 12, 2016 at 06:34:08PM +0200, Martin Schwidefsky wrote: > On Mon, 4 Apr 2016 16:26:35 +0200 > Heiko Carstens wrote: > > > On Mon, Apr 04, 2016 at 05:51:09PM +0530, Sudip Mukherjee wrote: > > > On Monday 04 April 2016 09:39 AM, Stephen Rothwell wrote: > > > >Hi all, > > > > > > > >Changes since 20160401: > > > > > > s390 allmodconfig build fails with the error: > > > > > > arch/s390/crypto/ghash_s390.c:14:24: fatal error: crypt_s390.h: No > > > such file or directory > > > #include "crypt_s390.h" > > > ^ > > > > > > build log is at: > > > https://travis-ci.org/sudipm-mukherjee/parport/jobs/120536718 > > > > > > caused by the commit - > > > ce69a690149c ("s390/crypto: cleanup and move the header with the > > > cpacf definitions") which removed the file "crypt_s390.h" > > > > Thanks for letting us know! > > > > I just removed that specific patch from the 'features' branch again. It was > > incomplete since it didn't convert the ghash module at all. > > > > No idea what Martin was thinking when pushing that patch. > > That is strange. On my local features branch that I use to push to kerne.org > there is no ghash commit. The last commit is this: Nobody said there is a ghash commit ;) > commit ce69a690149c7431d05b4679409ab8fa6ad3a09f > Author: Martin Schwidefsky > Date: Thu Mar 17 15:22:12 2016 +0100 > > s390/crypto: cleanup and move the header with the cpacf definitions > > which Heiko now removed. My guest right now is that the ghash commit stems > from another tree merged into linux-next and we simply have an unresolved > dependency here. I do have an updated ghash patch that includes the correct > header. Your patch did not convert/touch arch/s390/crypto/ghash_s390.c which is very old code. And you need to do more within that file than just changing the include.