From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030619AbcDMJvO (ORCPT ); Wed, 13 Apr 2016 05:51:14 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33690 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030425AbcDMJvL (ORCPT ); Wed, 13 Apr 2016 05:51:11 -0400 Date: Wed, 13 Apr 2016 11:51:07 +0200 From: Ingo Molnar To: Daniel Lezcano Cc: peterz@infradead.org, Ingo Molnar , "open list:SCHEDULER" Subject: Re: [PATCH] sched/clock: Make local_clock/cpu_clock inline Message-ID: <20160413095107.GD6430@gmail.com> References: <1459541050-13654-1-git-send-email-daniel.lezcano@linaro.org> <20160413094158.GA6430@gmail.com> <570E1562.8050906@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <570E1562.8050906@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Daniel Lezcano wrote: > On 04/13/2016 11:41 AM, Ingo Molnar wrote: > > > >* Daniel Lezcano wrote: > > > >>The local_clock/cpu_clock functions were changed to prevent a double > >>identical test with sched_clock_cpu() when HAVE_UNSTABLE_SCHED_CLOCK > >>is set. That resulted in one line functions. > >> > >>As these functions are in all the cases one line functions and in the > >>hot path, it is useful to specify them as static inline in order to > >>give a strong hint to the compiler. > >> > >>After verification, it appears the compiler does not inline them > >>without this hint. Change those functions to static inline. > >> > >>Signed-off-by: Daniel Lezcano > >>--- > >> include/linux/sched.h | 32 ++++++++++++++++++++++++++++++-- > >> kernel/sched/clock.c | 41 ----------------------------------------- > >> 2 files changed, 30 insertions(+), 43 deletions(-) > > > >Hm, this does not seem to apply to v4.6-rc3 cleanly. > > Actually I based the patches on top of tip/sched/core. This patch does not seem to apply to tip/sched/core either (2b8c41daba32). Thanks, Ingo