From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753527AbcDNKBe (ORCPT ); Thu, 14 Apr 2016 06:01:34 -0400 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:46290 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751886AbcDNKBd (ORCPT ); Thu, 14 Apr 2016 06:01:33 -0400 Authentication-Results: ppops.net; spf=none smtp.mail=ckeepax@opensource.wolfsonmicro.com Date: Thu, 14 Apr 2016 11:01:35 +0100 From: Charles Keepax To: Dan Carpenter CC: Lee Jones , Mark Brown , , , Subject: Re: [patch] mfd: wm8400-core: signedness bug in wm8400_reg_read() Message-ID: <20160414100135.GS31814@localhost.localdomain> References: <20160414094055.GC16891@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160414094055.GC16891@mwanda> User-Agent: Mutt/1.5.23 (2014-03-12) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1603180000 definitions=main-1604140143 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 14, 2016 at 12:40:55PM +0300, Dan Carpenter wrote: > This is harmless because the function is not called, but we're trying to > return negative error codes so the function needs to return an int > instead of a u16. > > Signed-off-by: Dan Carpenter That patch looks fine, but the function appears to be completely unused, perhaps just a patch to remove it would be better? Thanks, Charles