From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964813AbcDNPS3 (ORCPT ); Thu, 14 Apr 2016 11:18:29 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:41758 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756448AbcDNPS1 (ORCPT ); Thu, 14 Apr 2016 11:18:27 -0400 Date: Thu, 14 Apr 2016 16:18:15 +0100 From: Mark Brown To: Srinivas Kandagatla Cc: Greg Kroah-Hartman , Maxime Ripard , linux-kernel@vger.kernel.org, rjendra@qti.qualcomm.com Message-ID: <20160414151815.GG18024@sirena.org.uk> References: <1460569154-25030-1-git-send-email-srinivas.kandagatla@linaro.org> <1460569154-25030-4-git-send-email-srinivas.kandagatla@linaro.org> <20160414064229.GC18024@sirena.org.uk> <570F8E77.5090202@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xs+9IvWevLaxKUtW" Content-Disposition: inline In-Reply-To: <570F8E77.5090202@linaro.org> X-Cookie: McDonald's -- Because you're worth it. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v1 3/3] nvmem: core: fix regmap accessor usage X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --xs+9IvWevLaxKUtW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 14, 2016 at 01:35:03PM +0100, Srinivas Kandagatla wrote: > I totally agree that there is an abstraction failure here in both sides. It > should be fixed. moving to using bulk apis would solve the nvmem problem for > now. But for long term, using regmap should be totally removed from nvmem > and directly use the reg read/write callbacks from nvmem providers, This > would be much robust solution. This was indeed Maxime's first proposal. I > will try to fix it up and see how it looks without regmap. OK, so just replacing all the _raw_ calls with _bulk_ for now? If you're doing that watch out for the fact that the reads come back native endian which might upset things. --xs+9IvWevLaxKUtW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXD7S1AAoJECTWi3JdVIfQ9i8H/ReULwW2F3i6tCfgAvP6hWMw LbazvhR8hUMUAZX4nHwTuLX+52ovU//JWTlX3VnL2ZRRa9R29dqFM90R6chbb3Kw odcfjF3ifPwFiyK1GdqE7kcuJAqlH/xtEYZ/jrlaO8u2zapmh4gTZxYlUE2oMyKU J1taSJQxrcR+s3KFit5okZEivxrNH+b5dbsTclyPvQ7B93pKbJ0bEXOamLfFWB4J gkHA7TUYWPSI84oDs0DLh3JmD0uBLNHI6wgC6PwQllkTRFlrBaduC4uT/0Y+3F4L oZlL/WhbOXVYvf8Llost7EiY9sELGo5/hviysyXKCY40we7u1Ht67bdI6xyyQWg= =WpPA -----END PGP SIGNATURE----- --xs+9IvWevLaxKUtW--