From: Mark Brown <broonie@kernel.org>
To: James Bans <James.Ban.opensource@diasemi.com>
Cc: LINUXKERNEL <linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Support Opensource <support.opensource@diasemi.com>
Subject: Re: [PATCH V1] regulator: pv88080: new regulator driver
Date: Thu, 14 Apr 2016 16:40:59 +0100 [thread overview]
Message-ID: <20160414154059.GI18024@sirena.org.uk> (raw)
In-Reply-To: <20160414075124.B874A5F7F3@krsrvapps-01.diasemi.com>
[-- Attachment #1: Type: text/plain, Size: 739 bytes --]
On Thu, Apr 14, 2016 at 04:32:04PM +0900, James Bans wrote:
A couple of minor points but otherwise this looks good:
> +static const int pv88080_buck2_limits[] = {
> + 1496000, 2393000, 3291000, 4189000
> +};
> +
> +static const int pv88080_buck3_limits[] = {
> + 1496000, 2393000, 3291000, 4189000
> +};
These two appear identical so should just be one array.
> + switch (data & PV88080_BUCK1_MODE_MASK) {
> + case PV88080_BUCK_MODE_SYNC:
> + mode = REGULATOR_MODE_FAST;
> + break;
> + case PV88080_BUCK_MODE_AUTO:
> + mode = REGULATOR_MODE_NORMAL;
> + break;
> + case PV88080_BUCK_MODE_SLEEP:
> + mode = REGULATOR_MODE_STANDBY;
> + break;
> + }
I know mode was initialized above but this would be clearer with a
default: case.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2016-04-14 15:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 7:32 [PATCH V1] regulator: pv88080: new regulator driver James Bans
2016-04-14 15:40 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160414154059.GI18024@sirena.org.uk \
--to=broonie@kernel.org \
--cc=James.Ban.opensource@diasemi.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).