linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon@arm.com>
To: "Shi, Yang" <yang.shi@linaro.org>
Cc: catalin.marinas@arm.com, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linaro-kernel@lists.linaro.org
Subject: Re: [PATCH] arm64: Kconfig: make SCHED_MC and SCHED_SMT depend on SMP
Date: Thu, 14 Apr 2016 17:35:38 +0100	[thread overview]
Message-ID: <20160414163538.GF4584@arm.com> (raw)
In-Reply-To: <570FC643.3090805@linaro.org>

On Thu, Apr 14, 2016 at 09:33:07AM -0700, Shi, Yang wrote:
> On 4/14/2016 1:47 AM, Will Deacon wrote:
> >On Wed, Apr 13, 2016 at 05:54:12PM -0700, Yang Shi wrote:
> >>SCHED_MC and SCHED_SMT are pointless when SMP is disabled.
> >>Although SMP is rarely disabled for ARM64, it looks more consistent to have
> >>such depend in Kconfig.
> >
> >You can't disable CONFIG_SMP for arm64 -- we select it unconditionally
> >in the kconfig.
> 
> Thanks Will. I didn't realize ARM64 has SMP selected unconditionally, it
> looks the patch is pointless.
> 
> A follow-up question, I know ARM64 has no UP implementation now, it sounds
> make sense to have SMP select unconditionally, however, it might be more
> flexible to have SMP like x86 and other architectures. And, it may also help
> to find more bugs when !SMP.

Well, an SMP kernel would still work on a UP implementation, so I don't
really see the point in carrying a whole load of barely tested #ifdef
code. Top that off with the fact that we still need shareable memory for
coherent DMA and we still need barrier instructions for the page table
walker, and it's really diminishing returns.

Will

      reply	other threads:[~2016-04-14 16:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-14  0:54 [PATCH] arm64: Kconfig: make SCHED_MC and SCHED_SMT depend on SMP Yang Shi
2016-04-14  8:47 ` Will Deacon
2016-04-14 16:33   ` Shi, Yang
2016-04-14 16:35     ` Will Deacon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160414163538.GF4584@arm.com \
    --to=will.deacon@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yang.shi@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).