From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Joshua Henderson <joshua.henderson@microchip.com>,
open list <linux-kernel@vger.kernel.org>,
linux-mips@linux-mips.org, ralf@linux-mips.org,
Andrei Pistirica <andrei.pistirica@microchip.com>,
Jiri Slaby <jslaby@suse.com>,
linux-serial@vger.kernel.org, linux-api@vger.kernel.org
Subject: Re: [PATCH v5 10/14] serial: pic32_uart: Add PIC32 UART driver
Date: Sat, 16 Apr 2016 09:09:50 -0700 [thread overview]
Message-ID: <20160416160950.GD10824@kroah.com> (raw)
In-Reply-To: <CAPKp9uYOnhJhNq8YDVRMpLSmGa7yWsktYnhVsMdWLtH1Jru3bw@mail.gmail.com>
On Fri, Apr 15, 2016 at 06:28:32PM +0100, Sudeep Holla wrote:
> Hi Greg,
>
> I just noticed this now. I am having similar issue with MPS2 UART driver
> posted @[1], hence I am asking here to get some clarification myself.
> Sorry for replying on very old thread.
>
> On Thu, Jan 14, 2016 at 1:15 AM, Joshua Henderson
> <joshua.henderson@microchip.com> wrote:
> > From: Andrei Pistirica <andrei.pistirica@microchip.com>
> >
> > This adds UART and a serial console driver for Microchip PIC32 class
> > devices.
> >
> > Signed-off-by: Andrei Pistirica <andrei.pistirica@microchip.com>
> > Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
> > Cc: Ralf Baechle <ralf@linux-mips.org>
>
> [...]
>
> > diff --git a/include/uapi/linux/serial_core.h b/include/uapi/linux/serial_core.h
> > index 93ba148..9df0a98 100644
> > --- a/include/uapi/linux/serial_core.h
> > +++ b/include/uapi/linux/serial_core.h
> > @@ -261,4 +261,7 @@
> > /* STM32 USART */
> > #define PORT_STM32 113
> >
> > +/* Microchip PIC32 UART */
> > +#define PORT_PIC32 114
>
> This was posted before v4.6-rc1 similar to MPS2 UART and has taken
> port# 114 for it. However MVEBU UART obtained 114 with v4.6-rc1
> And MPS2 UART was assigned 115 when it got revised/reposted.
>
> I also see this patch in linux-next with 114 itself as its port number.
> So the allocation of port number needs to be resolved before it gets
> merged or it's OK to wait for v4.7-rc1 ?
>
> If it's former, can PORT_PIC32 take 116 as the latest post of MPS2 assigned
> it 115 and I have pulled the same to take it via arm-soc.
>
> I am fine with any solution, just want to be notified if I need to
> take any action.
Just do the merge so the numbers are allocated in sequence.
We really need to fix this up one of these days, there's no real need
for these numbers, and it's a pain in merging, as you have found out...
thanks,
greg k-h
next prev parent reply other threads:[~2016-04-16 16:09 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 1:15 [PATCH v5 00/14] Initial Microchip PIC32MZDA Support Joshua Henderson
2016-01-14 1:15 ` [PATCH v5 01/14] dt/bindings: Add bindings for PIC32 interrupt controller Joshua Henderson
2016-01-17 3:57 ` Rob Herring
2016-01-14 1:15 ` [PATCH v5 02/14] irqchip: irq-pic32-evic: Add support " Joshua Henderson
2016-01-14 8:10 ` Thomas Gleixner
2016-01-14 11:12 ` Ralf Baechle
2016-01-14 1:15 ` [PATCH v5 03/14] dt/bindings: Add PIC32 clock binding documentation Joshua Henderson
2016-01-14 1:15 ` [PATCH v5 04/14] clk: clk-pic32: Add PIC32 clock driver Joshua Henderson
2016-01-26 17:04 ` Joshua Henderson
2016-01-29 23:58 ` Stephen Boyd
2016-02-03 5:36 ` Purna Chandra Mandal
2016-01-14 1:15 ` [PATCH v5 05/14] dt/bindings: Add bindings for PIC32/MZDA platforms Joshua Henderson
2016-01-14 1:15 ` [PATCH v5 06/14] MIPS: Add support for PIC32MZDA platform Joshua Henderson
2016-01-14 1:15 ` [PATCH v5 07/14] dt/bindings: Add bindings for PIC32 pin control and GPIO Joshua Henderson
2016-01-14 1:15 ` [PATCH v5 08/14] pinctrl: pinctrl-pic32: Add PIC32 pin control driver Joshua Henderson
2016-01-26 17:04 ` Joshua Henderson
2016-01-27 13:49 ` Linus Walleij
2016-01-28 0:33 ` Joshua Henderson
2016-01-14 1:15 ` [PATCH v5 09/14] dt/bindings: Add bindings for PIC32 UART driver Joshua Henderson
2016-01-14 1:15 ` [PATCH v5 10/14] serial: pic32_uart: Add " Joshua Henderson
2016-01-14 13:55 ` One Thousand Gnomes
2016-01-26 17:04 ` Joshua Henderson
2016-01-26 17:33 ` Greg Kroah-Hartman
2016-01-27 15:55 ` Joshua Henderson
2016-02-07 7:04 ` Greg Kroah-Hartman
2016-04-15 17:28 ` Sudeep Holla
2016-04-16 16:09 ` Greg Kroah-Hartman [this message]
2016-01-14 1:15 ` [PATCH v5 11/14] dt/bindings: Add bindings for PIC32 SDHCI host controller Joshua Henderson
2016-02-08 9:58 ` Ulf Hansson
2016-01-14 1:15 ` [PATCH v5 12/14] mmc: sdhci-pic32: Add PIC32 SDHCI host controller driver Joshua Henderson
2016-01-26 17:04 ` Joshua Henderson
2016-02-08 9:59 ` Ulf Hansson
2016-01-14 1:15 ` [PATCH v5 13/14] MIPS: dts: Add initial DTS for the PIC32MZDA Starter Kit Joshua Henderson
2016-01-14 1:15 ` [PATCH v5 14/14] MIPS: pic32mzda: Add initial PIC32MZDA Starter Kit defconfig Joshua Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160416160950.GD10824@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andrei.pistirica@microchip.com \
--cc=joshua.henderson@microchip.com \
--cc=jslaby@suse.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-serial@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).