From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751552AbcDQWwX (ORCPT ); Sun, 17 Apr 2016 18:52:23 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:45697 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751011AbcDQWwW (ORCPT ); Sun, 17 Apr 2016 18:52:22 -0400 Date: Sun, 17 Apr 2016 18:52:09 -0400 (EDT) Message-Id: <20160417.185209.2274621456744786466.davem@davemloft.net> To: arnd@arndb.de Cc: sd@queasysnail.net, hannes@stressinduktion.org, johannes@sipsolutions.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] macsec: fix crypto Kconfig dependency From: David Miller In-Reply-To: <1460884918-2879720-1-git-send-email-arnd@arndb.de> References: <1460884918-2879720-1-git-send-email-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 17 Apr 2016 15:52:21 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Sun, 17 Apr 2016 11:19:55 +0200 > The new MACsec driver uses the AES crypto algorithm, but can be configured > even if CONFIG_CRYPTO is disabled, leading to a build error: > > warning: (MAC80211 && MACSEC) selects CRYPTO_GCM which has unmet direct dependencies (CRYPTO) > warning: (BT && CEPH_LIB && INET && MAC802154 && MAC80211 && BLK_DEV_RBD && MACSEC && AIRO_CS && LIBIPW && HOSTAP && USB_WUSB && RTLLIB_CRYPTO_CCMP && FS_ENCRYPTION && EXT4_ENCRYPTION && CEPH_FS && BIG_KEYS && ENCRYPTED_KEYS) selects CRYPTO_AES which has unmet direct dependencies (CRYPTO) > crypto/built-in.o: In function `gcm_enc_copy_hash': > aes_generic.c:(.text+0x2b8): undefined reference to `crypto_xor' > aes_generic.c:(.text+0x2dc): undefined reference to `scatterwalk_map_and_copy' > > This adds an explicit 'select CRYPTO' statement the way that other > drivers handle it. > > Signed-off-by: Arnd Bergmann > Fixes: c09440f7dcb3 ("macsec: introduce IEEE 802.1AE driver") Applied, thanks Arnd.