From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753346AbcDRQnU (ORCPT ); Mon, 18 Apr 2016 12:43:20 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:54046 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751799AbcDRQnS (ORCPT ); Mon, 18 Apr 2016 12:43:18 -0400 Date: Mon, 18 Apr 2016 12:43:16 -0400 (EDT) Message-Id: <20160418.124316.1862068166928198574.davem@davemloft.net> To: herbert@gondor.apana.org.au Cc: arnd@arndb.de, sd@queasysnail.net, hannes@stressinduktion.org, johannes@sipsolutions.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] macsec: fix crypto Kconfig dependency From: David Miller In-Reply-To: <20160418104336.GA19175@gondor.apana.org.au> References: <20160418080202.GA18155@gondor.apana.org.au> <11585265.Dbvl2xi4u3@wuerfel> <20160418104336.GA19175@gondor.apana.org.au> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 18 Apr 2016 09:43:18 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Herbert Xu Date: Mon, 18 Apr 2016 18:43:36 +0800 > Right, the problem is that nothing within crypto ever selects > CRYPTO since it's also used as a way of hiding the crypto menu > options. As far as I understand it, this won't help. Because selects do not trigger other selects and dependencies. This is why we always must list all leaf node dependencies with select statements, rather than just the specific feature one needs.