From: Christoph Hellwig <hch@infradead.org>
To: okaya@codeaurora.org
Cc: Christoph Hellwig <hch@infradead.org>,
linux-rdma@vger.kernel.org, timur@codeaurora.org,
cov@codeaurora.org, Yishai Hadas <yishaih@mellanox.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] net: ethernet: mellanox: correct page conversion
Date: Mon, 18 Apr 2016 06:10:58 -0700 [thread overview]
Message-ID: <20160418131058.GA25421@infradead.org> (raw)
In-Reply-To: <0c6a430c5f0ec64f51d7c594ef9751dd@codeaurora.org>
On Mon, Apr 18, 2016 at 09:06:18AM -0400, okaya@codeaurora.org wrote:
> On 2016-04-18 08:12, Christoph Hellwig wrote:
> >On Sat, Apr 16, 2016 at 06:23:32PM -0400, Sinan Kaya wrote:
> >>Current code is assuming that the address returned by dma_alloc_coherent
> >>is a logical address. This is not true on ARM/ARM64 systems.
> >
> >Can you explain what you mean with a 'logical address' and what actual
> >issue you're trying to solve?
>
> Vmap call is failing on arm64 systems because dma alloc api already returns
> an address mapped with vmap.
Please state your problem clearly. What I'm reverse engineering from
your posts is: because dma_alloc_coherent uses vmap-like mappings on
arm64 (all, some systems?) a driver using a lot of them might run into
limits of the vmap pool size.
Is this correct?
>
> Please see arch/arm64/mm directory.
---end quoted text---
next prev parent reply other threads:[~2016-04-18 13:11 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-16 22:23 [PATCH V2] net: ethernet: mellanox: correct page conversion Sinan Kaya
2016-04-18 4:00 ` David Miller
2016-04-18 5:06 ` okaya
2016-04-18 15:59 ` David Miller
2016-04-18 16:06 ` Sinan Kaya
2016-04-18 6:54 ` Eli Cohen
2016-04-18 13:53 ` Sinan Kaya
2016-04-18 14:05 ` Eli Cohen
2016-04-18 14:32 ` Christoph Hellwig
2016-04-18 14:39 ` Eli Cohen
2016-04-18 15:17 ` Christoph Hellwig
2016-04-18 15:21 ` Sinan Kaya
2016-04-18 15:40 ` Christoph Hellwig
2016-04-18 17:47 ` Sinan Kaya
2016-04-19 7:50 ` Sinan Kaya
2016-04-18 12:12 ` Christoph Hellwig
2016-04-18 13:06 ` okaya
2016-04-18 13:10 ` Christoph Hellwig [this message]
2016-04-18 13:49 ` Sinan Kaya
2016-04-18 13:59 ` Christoph Hellwig
2016-04-18 15:15 ` Timur Tabi
2016-04-18 15:22 ` Sinan Kaya
2016-04-19 18:22 ` Christoph Hellwig
2016-04-19 18:37 ` Sinan Kaya
2016-04-20 11:08 ` Eran Ben Elisha
2016-04-20 13:35 ` Sinan Kaya
2016-04-20 13:38 ` Sinan Kaya
2016-04-20 13:41 ` Timur Tabi
2016-04-20 18:40 ` Eran Ben Elisha
2016-04-20 18:42 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160418131058.GA25421@infradead.org \
--to=hch@infradead.org \
--cc=cov@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=timur@codeaurora.org \
--cc=yishaih@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).