From: Michael Grzeschik <mgr@pengutronix.de>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Luis R . Rodriguez" <mcgrof@kernel.org>,
Josh Triplett <josh@joshtriplett.org>
Subject: Re: [PATCH 2/5] arcnet: com90xx: add __init attribute
Date: Tue, 19 Apr 2016 08:56:57 +0200 [thread overview]
Message-ID: <20160419065657.GD2471@pengutronix.de> (raw)
In-Reply-To: <1460991338-9845-3-git-send-email-Julia.Lawall@lip6.fr>
On Mon, Apr 18, 2016 at 04:55:35PM +0200, Julia Lawall wrote:
> Add __init attribute on a function that is only called from other __init
> functions and that is not inlined, at least with gcc version 4.8.4 on an
> x86 machine with allyesconfig. Currently, the function is put in the
> .text.unlikely segment. Declaring it as __init will cause it to be put in
> the .init.text and to disappear after initialization.
>
> The result of objdump -x on the function before the change is as follows:
>
> 0000000000000000 l F .text.unlikely 00000000000000bf check_mirror
>
> And after the change it is as follows:
>
> 0000000000000000 l F .init.text 00000000000000ba check_mirror
>
> Done with the help of Coccinelle. The semantic patch checks for local
> static non-init functions that are called from an __init function and are
> not called from any other function.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
Acked-by: Michael Grzeschik <mgr@pengutronix.de>
> ---
> drivers/net/arcnet/com90xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/arcnet/com90xx.c b/drivers/net/arcnet/com90xx.c
> index 0d9b45f..81f90c4 100644
> --- a/drivers/net/arcnet/com90xx.c
> +++ b/drivers/net/arcnet/com90xx.c
> @@ -433,7 +433,7 @@ static void __init com90xx_probe(void)
> kfree(iomem);
> }
>
> -static int check_mirror(unsigned long addr, size_t size)
> +static int __init check_mirror(unsigned long addr, size_t size)
> {
> void __iomem *p;
> int res = -1;
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2016-04-19 6:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 14:55 [PATCH 0/5] add __init attribute Julia Lawall
2016-04-18 14:55 ` [PATCH 1/5] clk: qoriq: " Julia Lawall
2016-04-18 18:53 ` Stephen Boyd
2016-04-18 14:55 ` [PATCH 2/5] arcnet: com90xx: " Julia Lawall
2016-04-19 6:56 ` Michael Grzeschik [this message]
2016-04-20 0:18 ` David Miller
2016-04-18 14:55 ` [PATCH 3/5] clocksource/drivers/mtk_timer: " Julia Lawall
2016-04-18 15:51 ` Matthias Brugger
2016-04-18 16:44 ` Daniel Lezcano
2016-04-18 14:55 ` [PATCH 4/5] TTY: " Julia Lawall
2016-04-18 14:55 ` [PATCH 5/5] cmd640: " Julia Lawall
2016-07-26 22:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160419065657.GD2471@pengutronix.de \
--to=mgr@pengutronix.de \
--cc=Julia.Lawall@lip6.fr \
--cc=josh@joshtriplett.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).