From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752176AbcDRVo7 (ORCPT ); Mon, 18 Apr 2016 17:44:59 -0400 Received: from ozlabs.org ([103.22.144.67]:37160 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751200AbcDRVo6 (ORCPT ); Mon, 18 Apr 2016 17:44:58 -0400 Date: Tue, 19 Apr 2016 07:44:55 +1000 From: Stephen Rothwell To: David Miller Cc: herbert@gondor.apana.org.au, arnd@arndb.de, sd@queasysnail.net, hannes@stressinduktion.org, johannes@sipsolutions.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] macsec: fix crypto Kconfig dependency Message-ID: <20160419074455.10a96986@canb.auug.org.au> In-Reply-To: <20160418.124316.1862068166928198574.davem@davemloft.net> References: <20160418080202.GA18155@gondor.apana.org.au> <11585265.Dbvl2xi4u3@wuerfel> <20160418104336.GA19175@gondor.apana.org.au> <20160418.124316.1862068166928198574.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dave, On Mon, 18 Apr 2016 12:43:16 -0400 (EDT) David Miller wrote: > > From: Herbert Xu > Date: Mon, 18 Apr 2016 18:43:36 +0800 > > > Right, the problem is that nothing within crypto ever selects > > CRYPTO since it's also used as a way of hiding the crypto menu > > options. > > As far as I understand it, this won't help. Because selects do not > trigger other selects and dependencies. My understanding is that selects trigger other selects, but do not honour dependencies. So, in general, you should not select a symbol that has dependencies (unless you also have the same dependencies or select those dependencies). -- Cheers, Stephen Rothwell