From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753430AbcDSLfG (ORCPT ); Tue, 19 Apr 2016 07:35:06 -0400 Received: from mail.skyhub.de ([78.46.96.112]:54233 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753214AbcDSLfE (ORCPT ); Tue, 19 Apr 2016 07:35:04 -0400 Date: Tue, 19 Apr 2016 13:35:01 +0200 From: Borislav Petkov To: Ingo Molnar Cc: peterz@infradead.org, dsafonov@virtuozzo.com, luto@kernel.org, hpa@zytor.com, dvlasenk@redhat.com, luto@amacapital.net, torvalds@linux-foundation.org, brgerst@gmail.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/asm] x86/entry: Rename is_{ia32,x32}_task() to in_{ia32,x32}_syscall() Message-ID: <20160419113501.GA10638@cz.tnic> References: <1460987025-30360-1-git-send-email-dsafonov@virtuozzo.com> <20160419111530.GA1619@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160419111530.GA1619@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 19, 2016 at 01:15:30PM +0200, Ingo Molnar wrote: > So I'd suggest the following renames to harmonize these concepts: > > - CONFIG_IA32_EMULATION => CONFIG_X86_32_ABI > this lines up nicely with: CONFIG_X86_X32_ABI Except that the only difference now is the "X" in the strings. So one would need more coffee when staring at those. :) > > - is_ia32_syscall() -> is_x86_32_syscall() > - is_x32_syscall() -> is_x86_x32_syscall() > > - is_compat_syscall() remains as-is. > > ... thoughts? Still, getting those names streamlined and logical is a step in the right direction IMO. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. Srsly.