From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751681AbcDTVpT (ORCPT ); Wed, 20 Apr 2016 17:45:19 -0400 Received: from mail-pf0-f176.google.com ([209.85.192.176]:35745 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751069AbcDTVpR (ORCPT ); Wed, 20 Apr 2016 17:45:17 -0400 Date: Wed, 20 Apr 2016 14:45:13 -0700 From: Brian Norris To: Guenter Roeck Cc: Olof Johansson , dianders@chromium.org, gwendal@chromium.org, linux-kernel@vger.kernel.org Subject: Re: platform/chrome: cros_ec_dev - Populate compat_ioctl Message-ID: <20160420214513.GA78825@google.com> References: <1460687729-5860-1-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460687729-5860-1-git-send-email-linux@roeck-us.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 14, 2016 at 07:35:29PM -0700, Guenter Roeck wrote: > compat_ioctl has to be populated for 32 bit userspace applications to work > with 64 bit kernels. > > Signed-off-by: Guenter Roeck Tested with 32-bit user space on ARM64: Tested-by: Brian Norris > --- > drivers/platform/chrome/cros_ec_dev.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/platform/chrome/cros_ec_dev.c b/drivers/platform/chrome/cros_ec_dev.c > index 6c45e0f5ba7b..903b1d8dcab7 100644 > --- a/drivers/platform/chrome/cros_ec_dev.c > +++ b/drivers/platform/chrome/cros_ec_dev.c > @@ -208,6 +208,9 @@ static const struct file_operations fops = { > .release = ec_device_release, > .read = ec_device_read, > .unlocked_ioctl = ec_device_ioctl, > +#ifdef CONFIG_COMPAT > + .compat_ioctl = ec_device_ioctl, > +#endif > }; > > static void __remove(struct device *dev)