From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751948AbcDVU6O (ORCPT ); Fri, 22 Apr 2016 16:58:14 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33962 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751172AbcDVU6N (ORCPT ); Fri, 22 Apr 2016 16:58:13 -0400 Date: Fri, 22 Apr 2016 13:58:12 -0700 From: Andrew Morton To: Huang Shijie Cc: , , , , Subject: Re: [PATCH] kprobes: add the "tls" argument for j_do_fork Message-Id: <20160422135812.657b9c02f65a94ac1c34cc45@linux-foundation.org> In-Reply-To: <1460625400-22319-1-git-send-email-shijie.huang@arm.com> References: <1460625400-22319-1-git-send-email-shijie.huang@arm.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Apr 2016 17:16:40 +0800 Huang Shijie wrote: > The patch "3033f14a clone: support passing tls argument via C rather ..." > added the tls argument for _do_fork(). The patch adds the "tls" argument > for j_do_fork to make it match _do_fork(). > > ... > > --- a/samples/kprobes/jprobe_example.c > +++ b/samples/kprobes/jprobe_example.c > @@ -25,7 +25,7 @@ > /* Proxy routine having the same arguments as actual _do_fork() routine */ > static long j_do_fork(unsigned long clone_flags, unsigned long stack_start, > unsigned long stack_size, int __user *parent_tidptr, > - int __user *child_tidptr) > + int __user *child_tidptr, unsigned long tls) > { > pr_info("jprobe: clone_flags = 0x%lx, stack_start = 0x%lx " > "stack_size = 0x%lx\n", clone_flags, stack_start, stack_size); The changelog failed to tell us what are the runtime effects of this bug. Please always include this info so that others can decide which kernel version(s) need fixing. Thanks.