From: Tony Lindgren <tony@atomide.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Paul Walmsley <paul@pwsan.com>,
jarkko.nikula@bitmer.com, t-kristo@ti.com,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 0/3] ARM: OMAP3: Fix McBSP2/3 hwmod setup for sidetone
Date: Fri, 22 Apr 2016 15:24:15 -0700 [thread overview]
Message-ID: <20160422222415.GN5995@atomide.com> (raw)
In-Reply-To: <571A2357.3060006@ti.com>
* Peter Ujfalusi <peter.ujfalusi@ti.com> [160422 06:15]:
>
> From the documents it is also clear that McBSPLP.sidetone is using the
> McBSPLP's ICLK, but what is not explained in the TRM is that there are
> internal clocks going from McBSP to sidetone for the data bus between them.
> The iclk is needed so the core can kind of run independently from the clocks
> coming from McBSPLP (for data exchange between the two modules).
> If McBSP is not configured these clocks are not running which renders the
> sidetone non operational.
THe McBSP ick is not coming from McBSP, it's coming from the L4
interconnect. Both McBSP are just consumers for that same clock.
AFAIK there is no clock line going from McBSP to the sidetone.
> I can send a cut down series to fix the current sidetone hwmod (main_clk and
> prevent it to look at the PRCM bit) plus reworking the pdata callback so we
> can support both legacy and DT boot.
OK sounds good to me :)
Tony
prev parent reply other threads:[~2016-04-22 22:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 14:23 [PATCH v2 0/3] ARM: OMAP3: Fix McBSP2/3 hwmod setup for sidetone Peter Ujfalusi
2016-03-18 14:23 ` [PATCH v2 1/3] ARM: DTS: omap3: Remove mcbsp2/3_sidetone hwmod reference for McBSP2/3 Peter Ujfalusi
2016-03-18 14:23 ` [PATCH v2 2/3] ARM: OMAP2+: mcbsp: Prepare the device build code for sidetone hwmod removal Peter Ujfalusi
2016-03-18 14:23 ` [PATCH v2 3/3] ARM: OMAP3: hwmod data: Merge and remove the McBSP sidetone related data Peter Ujfalusi
2016-03-19 19:38 ` [PATCH v2 0/3] ARM: OMAP3: Fix McBSP2/3 hwmod setup for sidetone Paul Walmsley
2016-03-21 8:57 ` Peter Ujfalusi
2016-03-21 17:44 ` Paul Walmsley
2016-04-01 9:33 ` Peter Ujfalusi
2016-04-02 0:17 ` Tony Lindgren
2016-04-04 12:45 ` Peter Ujfalusi
2016-04-04 15:12 ` Tony Lindgren
2016-04-05 13:15 ` Peter Ujfalusi
2016-04-11 21:28 ` Tony Lindgren
2016-04-12 9:52 ` Peter Ujfalusi
2016-04-12 16:37 ` Tony Lindgren
2016-04-13 11:57 ` Peter Ujfalusi
2016-04-13 15:28 ` Tony Lindgren
2016-04-14 7:34 ` Peter Ujfalusi
2016-04-14 16:55 ` Tony Lindgren
2016-04-14 19:37 ` Peter Ujfalusi
2016-04-14 20:34 ` Tony Lindgren
2016-04-15 10:23 ` Peter Ujfalusi
2016-04-15 15:16 ` Tony Lindgren
2016-04-15 19:50 ` Peter Ujfalusi
2016-04-18 23:51 ` Tony Lindgren
2016-04-22 13:12 ` Peter Ujfalusi
2016-04-22 22:24 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160422222415.GN5995@atomide.com \
--to=tony@atomide.com \
--cc=devicetree@vger.kernel.org \
--cc=jarkko.nikula@bitmer.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=peter.ujfalusi@ti.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).