From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754242AbcDYJTA (ORCPT ); Mon, 25 Apr 2016 05:19:00 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([146.101.78.143]:51341 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754051AbcDYJS6 convert rfc822-to-8bit (ORCPT ); Mon, 25 Apr 2016 05:18:58 -0400 Date: Mon, 25 Apr 2016 17:18:25 +0800 From: Huang Shijie To: Andrew Morton CC: , , , , Subject: Re: [PATCH] kprobes: add the "tls" argument for j_do_fork Message-ID: <20160425091823.GA10523@sha-win-210.asiapac.arm.com> References: <1460625400-22319-1-git-send-email-shijie.huang@arm.com> <20160422135812.657b9c02f65a94ac1c34cc45@linux-foundation.org> MIME-Version: 1.0 In-Reply-To: <20160422135812.657b9c02f65a94ac1c34cc45@linux-foundation.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [217.140.104.200] X-ClientProxiedBy: TY1PR0201CA0016.apcprd02.prod.outlook.com (10.164.90.154) To HE1PR08MB0508.eurprd08.prod.outlook.com (10.161.120.155) X-MS-Office365-Filtering-Correlation-Id: 68ad7367-e28c-4640-3f3c-08d36cea9dea X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB0508;2:eiF2tcFlrqLdQaUKGHV5UzhuGfz/Orwjr08YBV/FDDF6iNgwoY1PH6wQUvpEShvF45Rd1gvUaZWH70qDK9E29Zpg70Enn5ugf+oauiCBfv3mFxPGowhkvVhx6TWsWCTLdSjwbZB1Pv8G39PM6lyJeT6jYjwe2FfXLUdINi2PNzFElZmjXc83DrwmsH54WRd1;3:PeoaL9opb5WwJOcB8hRh9aYNDq5dKa00oEafBV8tV+9O3kuAJwd4/I1Sr4LxkdtMiaLo5LR+3cVyCZ6uBHO1f0tu8vanoC+vpeE3NTIOAno9XmXpZotuhnXJM9M3TSA1;25:iEL+C66IdK2/Nj6EqS3GYj0mM3rvb+1Q6dwn6fWuaS3TcHp2c4kKT+wuYOeryihy9Hj1X3euDKSUfNcZDfehhRRlvIKzC3dED2P5EsgjncBbmfcugsllzn5wGcoyhCfVyNMltupKwNY3tth/3azFdrkvhLMfsYB8dYBl8Yl9DxVHrzWdNnL7Mfg5yb5j+FakUY9MOJaE5b1resQQyGak5T7cEV8eifcht2wEZPfptoXyZVfAqpA8jf8X8UTEFGtuatYi/AsSP5zy/TeT5gwR4YOUvl86w523nMmeOmrszF7FxLaEVhZhlJ0LNODYKw0MSqNeXo+jgPfVZJcT4iAHhA==;20:+LwmfJjPZlkD8e1ESCwf14Dcc3URpuZQR7fS5f5SgloAaSBE8xp05QPmNWXAiNVKrulkh72g2ONn7tecIuEX2XLjUVBjpJyf1FFjycixx8nD3TmQFDlRH3v3BaXowN32CBINFonbY+ia+hwjUxG5nPiPTwFVVgpv708yFGE8n0g= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR08MB0508; NoDisclaimer: True X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(9101521026)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:HE1PR08MB0508;BCL:0;PCL:0;RULEID:;SRVR:HE1PR08MB0508; X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB0508;4:3Nm7mgC4kNbvvbdziDx8XnJKvBJuGnhDWYsacbifqjBqdJzLSL2KeLMTAhp/aILwZLdVP59ARihVpFPTpmyl3eBdGzyciyd4rM7gQ+CwUNUUamI5X6fUOOxowW29ZPXy6RJW6V7HwKGjVhf37oLu980J8msSkd66F32vcSCA91tcRr1jQiynRyJOT8HR9Mps+LUCwd8sPNX8gNkH+Tc5f23US5zPQKWm/CuoivP1t84+5DLJx48BBS6AWZFlLqwykohpBAnViWhEZ0JhkHVeFH41syOuSYOI7AjPyg6QMZhtO4zNs95dVZjwQk69VDTGr4lUYkXRrFYL4SB1efR4TonvvfdigoEeJkWQnqIlQLLRxq8ZY5WcYA9muqSCoDya8vg7xKGBZsu5ZbTRCZf0G5tB2MoRyEbN+imBMIqtBmA= X-Forefront-PRVS: 0923977CCA X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(24454002)(4001350100001)(42186005)(46406003)(86362001)(110136002)(77096005)(2950100001)(50466002)(54356999)(76176999)(50986999)(5004730100002)(47776003)(19580395003)(19580405001)(6116002)(2906002)(1076002)(23726003)(4326007)(97756001)(92566002)(586003)(3846002)(1096002)(83506001)(33656002)(189998001)(5008740100001)(81166005)(66066001);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR08MB0508;H:sha-win-210.asiapac.arm.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB0508;23:UDmdqT/G5gP14Xvc3LQtpN3fcEbkrvpD3vmHCVMFEF8DbsGb5Fv1rNU2w1r3IYO8zdmVZ6VJ9H3EJueaRDsepJ3AWvWDuXzdH3/nEHpI6CGOSY3Fxts0ew2/tiwmOCRfYinB3sBnBd/xC/aGy20MUHKzzazJN3P6D20JL3eRHx3pxy1yEXh7pR90VqShvxTigMad9uqEvEOejamSYJ20lDO3/Q22ssfjEO/SVehKB+LXcty6Tu+igsEdXG5IjQQhmhgsHnmI734xnD/YO5jQNSOSh3PmscKRHD+4rOEBSXarei2vgJBAEz7j+ceA3Ii7xUDvNjT3p19o92Hef646qfdyg8fhx+jw/gg0Fwxp999pASLByhl7QwCsST1aaWprs1v1MmDaHaOtV3OGeC/WiqY8Q0Gmba69Bk+T7PVBFBiCGmRhImKHRgkOMbImQBOCrhVSyMbUVTj9jq4JD9NSNmpO9XNoCUXIQ/0oU2wYxfa8pQjlELydmYycBu2iwQ2V9qXCqNUKJA6NUekbQa299Dj1oxzQ1Jk6r9xwiobUW9y3kfxUEkydxvsr6n/LYIPp+68sa3d+m0pGoY+M2Whjz1JsSzd2SGLT31+S0dge5WdYxeABPrTM6YNo/shubpg4PXWgjMyLy0eVseabYIdKOmpGXvms6GvII6w0qsF9JJ+fyUnziXUGsf75jwopMVWbTp4/MFflToIPkzwnllPbV4MLOZ5G2tdT9hik6khGOy5uRHujyjODMYo45AUFObunMYdoL/yVzZMCf/QrhGFQVEp2QLeVMv/eozv4J4imgMDI5SsqQ1bmACMIFLusPGlnUxhqM8daLsDfQwC5Da9RYwKkccBT6agEaDc8S7EnjLPxmqqmzE0auqLPgY90fXRy0puNOD6i13/RO4ZAq0N+wtJaMfhL/yETkvQpPqygSuY= X-Microsoft-Exchange-Diagnostics: 1;HE1PR08MB0508;5:Jg0ihUvRuzWVdNdfR7R79SqaIdmH7Ho3/1t3VXUqtfA8m1BdbD8lPgiJeosD8G1ewmsiSpjq9KuHRYkMT4/Np//il2AGI9wml/t+4HdOIscXC3Q3L0KiXoZReACOVeGjSf6GGSh5hNoZ0FSUCz3JHRavLHsD8iI5FTCVtrp+KjjAvhmq90eAj9Pg7ffB4O+s;24:qAX0ArdguL/UnOtSvsWP8fjC8mZlK1y08hKk/wnT5VYPLLA5qgOCIeuJ7llgu88DO6sWnq/I4JIH362a6ELBtQqtJt4kGWzwSorZ3us+BCU=;7:WX+zmpTc/pliKLX/2iAywrHLZ5B8jnz6Ta7RrdRZujMeB9QHJf9tJUc4PohmiCxbYAPeWRi18sBp+F6BjlbuRuni/hR4VQ/EsZHWl9QYsNvlTVmQMh9FogQP5rwamPCZDgb2LhMC9S/BQfFifCY5aNGeohmWPEWap2Aa5fcokRsIGKrieHu4vf+d8qB9sZxqek6PdX2tHFW/l0waaUnwjXpjGKOtbCC1MC6EwFXybCA=;20:yqhlfZeYU3ySoLaMwu3NI3udDa3puz2XKNmJeiZl53oEBSbzM4YPV17AzuS2AphbrB/QOIHI621cY226IfidMj7akXbeQOwxQYtLvGNdt4pKitRKdXEPtEa2/EI0TGyJvIPMMNOstYIeNhNMi0gaMb0p1tNzkWzCsMEyCqI4l7o= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2016 09:18:49.2049 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB0508 X-MC-Unique: 2dvvj5d9Sg2wIcCC8iCZVQ-1 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 22, 2016 at 01:58:12PM -0700, Andrew Morton wrote: > On Thu, 14 Apr 2016 17:16:40 +0800 Huang Shijie wrote: > > > The patch "3033f14a clone: support passing tls argument via C rather ..." > > added the tls argument for _do_fork(). The patch adds the "tls" argument > > for j_do_fork to make it match _do_fork(). > > > > ... > > > > --- a/samples/kprobes/jprobe_example.c > > +++ b/samples/kprobes/jprobe_example.c > > @@ -25,7 +25,7 @@ > > /* Proxy routine having the same arguments as actual _do_fork() routine */ > > static long j_do_fork(unsigned long clone_flags, unsigned long stack_start, > > unsigned long stack_size, int __user *parent_tidptr, > > - int __user *child_tidptr) > > + int __user *child_tidptr, unsigned long tls) > > { > > pr_info("jprobe: clone_flags = 0x%lx, stack_start = 0x%lx " > > "stack_size = 0x%lx\n", clone_flags, stack_start, stack_size); > > The changelog failed to tell us what are the runtime effects of this > bug. Please always include this info so that others can decide > which kernel version(s) need fixing. I really does not meet any issue with this bug, I just find it when i read the code. thanks Huang Shijie