From: Lee Jones <lee.jones@linaro.org>
To: Henry Chen <henryc.chen@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
John Crispin <blogic@openwrt.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Flora Fu <flora.fu@mediatek.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v3 2/2] dt-bindings: ARM: Mediatek: add interrupt as required properties to the mt6397/mt6323 doc
Date: Mon, 25 Apr 2016 11:57:50 +0100 [thread overview]
Message-ID: <20160425105750.GB2713@dell> (raw)
In-Reply-To: <1460709030-23820-2-git-send-email-henryc.chen@mediatek.com>
On Fri, 15 Apr 2016, Henry Chen wrote:
> MT6397/MT6323 have one interrupt line connected to the main SoC.
> Interrupt should be required feature of pmic, each sub module also
> need it to complete their function or error detect, add it as
> required properties on dts file.
>
> Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> ---
> Documentation/devicetree/bindings/mfd/mt6397.txt | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt
> index 949c85f..a96529e 100644
> --- a/Documentation/devicetree/bindings/mfd/mt6397.txt
> +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt
> @@ -15,7 +15,13 @@ Documentation/devicetree/bindings/soc/pwrap.txt
> This document describes the binding for MFD device and its sub module.
>
> Required properties:
> -compatible: "mediatek,mt6397" or "mediatek,mt6323"
> +- compatible: "mediatek,mt6397" or "mediatek,mt6323"
> +- interrupts: mt6323/mt6397 have one interrupt line connecteded to the main SoC
> +- interrupt-parent: The parent interrupt controller
> +- interrupt-controller : marks the device node as an interrupt controller
Nit: All sentences should start with an upper case char.
The device node is not an interrupt controller -- it's a device node.
The device the device node represents is the interrupt controller.
Look at how others describe this property, it's pretty well used.
> +- #interrupt-cells: the number of cells to describe an IRQ, this should be 2.
Nit: Captial letter.
> + The first cell is the IRQ number.
> + The second cell is the flags, encoded as the trigger masks from
>
> Optional subnodes:
>
> @@ -43,6 +49,10 @@ Example:
>
> pmic {
> compatible = "mediatek,mt6397";
> + interrupt-parent = <&pio>;
> + interrupts = <11 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
>
> codec: mt6397codec {
> compatible = "mediatek,mt6397-codec";
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-04-25 10:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 8:30 [PATCH v3 1/2] mfd: mt6397: irq domain should initialize before mfd_add_devices() Henry Chen
2016-04-15 8:30 ` [PATCH v3 2/2] dt-bindings: ARM: Mediatek: add interrupt as required properties to the mt6397/mt6323 doc Henry Chen
2016-04-25 10:57 ` Lee Jones [this message]
2016-04-25 10:54 ` [PATCH v3 1/2] mfd: mt6397: irq domain should initialize before mfd_add_devices() Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160425105750.GB2713@dell \
--to=lee.jones@linaro.org \
--cc=blogic@openwrt.org \
--cc=flora.fu@mediatek.com \
--cc=henryc.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).