From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Steven Rostedt" <rostedt@goodmis.org>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
"Ingo Molnar" <mingo@kernel.org>,
"Borislav Petkov" <bp@alien8.de>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH v2] printk: Add kernel parameter to disable writes to /dev/kmsg
Date: Mon, 25 Apr 2016 12:54:37 -0700 [thread overview]
Message-ID: <20160425195437.GA25465@kroah.com> (raw)
In-Reply-To: <20160425192435.GM3430@twins.programming.kicks-ass.net>
On Mon, Apr 25, 2016 at 09:24:35PM +0200, Peter Zijlstra wrote:
> On Mon, Apr 25, 2016 at 12:18:15PM -0700, Greg Kroah-Hartman wrote:
> > On Mon, Apr 25, 2016 at 09:06:51PM +0200, Peter Zijlstra wrote:
> > > On Mon, Apr 25, 2016 at 02:56:06PM -0400, Steven Rostedt wrote:
> > > > +static bool __read_mostly devkmsg_disabled;
> > > > +static int __init disable_devkmsg(char *str)
> > > > +{
> > > > + devkmsg_disabled = true;
> > > > + return 0;
> > > > +}
> > > > +__setup("printk.disable_kmsg_write", disable_devkmsg);
> > >
> > > Again, please default enable and use an easier name to toggle this.
> > > Userspace flooding this with junk is really insane.
> >
> > If you default enable, you break working systems today that want to log
> > stuff through this interface, sorry.
>
> Oh, you mean those 'working' systems that livelocked my box because I
> had console to serial enabled which could not keep up with the endless
> flood of shite?
>
> This systemd exposure has seriously eroded your sanity.
See Andrew's message, this was added because of klibc :)
next prev parent reply other threads:[~2016-04-25 19:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 18:56 [PATCH v2] printk: Add kernel parameter to disable writes to /dev/kmsg Steven Rostedt
2016-04-25 19:06 ` Peter Zijlstra
2016-04-25 19:18 ` Greg Kroah-Hartman
2016-04-25 19:24 ` Peter Zijlstra
2016-04-25 19:44 ` Andrew Morton
2016-04-25 19:54 ` Greg Kroah-Hartman [this message]
2016-04-25 20:00 ` Steven Rostedt
2016-04-25 20:23 ` Linus Torvalds
2016-04-25 20:34 ` Steven Rostedt
2016-04-25 20:45 ` Linus Torvalds
2016-04-25 21:23 ` Steven Rostedt
2016-04-26 11:01 ` Borislav Petkov
2016-04-26 11:12 ` Peter Zijlstra
2016-04-25 19:30 ` Steven Rostedt
2016-04-25 19:28 ` Linus Torvalds
2016-04-25 19:34 ` Linus Torvalds
2016-04-25 19:35 ` Steven Rostedt
2016-04-25 19:44 ` Steven Rostedt
2016-04-26 5:36 ` Ingo Molnar
2016-04-26 10:43 ` Bjørn Mork
2016-04-26 11:09 ` Peter Zijlstra
2016-04-25 19:46 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160425195437.GA25465@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).