From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752523AbcD1Rvc (ORCPT ); Thu, 28 Apr 2016 13:51:32 -0400 Received: from mga02.intel.com ([134.134.136.20]:58822 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752371AbcD1Rvb (ORCPT ); Thu, 28 Apr 2016 13:51:31 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,547,1455004800"; d="scan'208";a="968585789" Date: Thu, 28 Apr 2016 20:51:24 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Daniel Vetter Cc: Gustavo Padovan , Daniel Stone , Greg Hackmann , Gustavo Padovan , Daniel Stone , Riley Andrews , dri-devel , Linux Kernel Mailing List , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , John Harrison Subject: Re: [RFC v2 5/8] drm/fence: add in-fences support Message-ID: <20160428175124.GG4329@intel.com> References: <20160426172049.GB2558@phenom.ffwll.local> <20160426174045.GC4329@intel.com> <20160426182346.GC2558@phenom.ffwll.local> <20160426185506.GH4329@intel.com> <20160426200505.GD2558@phenom.ffwll.local> <571FD402.6050407@google.com> <20160428143644.GA3496@joana> <20160428165619.GD4329@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 28, 2016 at 07:43:16PM +0200, Daniel Vetter wrote: > On Thu, Apr 28, 2016 at 6:56 PM, Ville Syrjälä > wrote: > >> - better for tracing, can identify the buffer/fence promptly > > > > Can fences be reused somehow while still attached to a plane, or ever? > > That might cause some oddness if you, say, leave a fence attached to one > > plane and then do a modeset on another crtc perhaps which needs to turn > > the first crtc off+on to reconfigure something. > > Fences auto-disappear of course and don't stick around when you > duplicate the drm_plane_state again. I still don't really get the real > concerns though ... Properties that magically change values shouldn't exist IMO. I guess if you could have write-only properties or something it migth be sensible? > In the end it's purely a transport question, and > both ABI ideas work out semantically exactly the same in the end. It's > just that at least in my opinion FENCE_FD prop is a lot more > convenient. > -Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- Ville Syrjälä Intel OTC