linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Akshay Bhat <akshay.bhat@timesys.com>
Cc: p.zabel@pengutronix.de, airlied@linux.ie,
	steve_longerbeam@mentor.com, dri-devel@lists.freedesktop.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: imx: ldb: Add ddc-i2c-bus property
Date: Thu, 28 Apr 2016 16:48:23 -0500	[thread overview]
Message-ID: <20160428214823.GA841@rob-hp-laptop> (raw)
In-Reply-To: <1461788614-7784-2-git-send-email-akshay.bhat@timesys.com>

On Wed, Apr 27, 2016 at 04:23:34PM -0400, Akshay Bhat wrote:
> Document the ddc-i2c-bus property used by imx-ldb driver to read EDID
> information via I2C interface.
> 
> Signed-off-by: Akshay Bhat <akshay.bhat@timesys.com>
> ---
> 
> v3:
> Newly added.
> 
>  Documentation/devicetree/bindings/display/imx/ldb.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/imx/ldb.txt b/Documentation/devicetree/bindings/display/imx/ldb.txt
> index 0a175d9..a407462 100644
> --- a/Documentation/devicetree/bindings/display/imx/ldb.txt
> +++ b/Documentation/devicetree/bindings/display/imx/ldb.txt
> @@ -62,6 +62,7 @@ Required properties:
>     display-timings are used instead.
>  
>  Optional properties (required if display-timings are used):

The required part doesn't make sense if you add this, but...

> + - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing

Really, this should be part of a connector node since i2c goes from the 
i2c controller to a connector and is not part of the display controller.

>   - display-timings : A node that describes the display timings as defined in
>     Documentation/devicetree/bindings/display/display-timing.txt.
>   - fsl,data-mapping : should be "spwg" or "jeida"
> -- 
> 2.8.1
> 

  reply	other threads:[~2016-04-28 21:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-27 20:23 [PATCH v3 1/2] drm/imx: imx-ldb: Add DDC support Akshay Bhat
2016-04-27 20:23 ` [PATCH v3 2/2] dt-bindings: imx: ldb: Add ddc-i2c-bus property Akshay Bhat
2016-04-28 21:48   ` Rob Herring [this message]
2016-04-29  7:44     ` Philipp Zabel
2016-05-03 16:06       ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160428214823.GA841@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=airlied@linux.ie \
    --cc=akshay.bhat@timesys.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=steve_longerbeam@mentor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).