From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752293AbcD2Iu3 (ORCPT ); Fri, 29 Apr 2016 04:50:29 -0400 Received: from down.free-electrons.com ([37.187.137.238]:60470 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750847AbcD2Iu0 (ORCPT ); Fri, 29 Apr 2016 04:50:26 -0400 Date: Fri, 29 Apr 2016 10:50:23 +0200 From: Boris Brezillon To: Han Xu Cc: , , , , , , , , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] mtd: nand: gpmi: document the clocks and clock-names in DT property Message-ID: <20160429105023.0209995a@bbrezillon> In-Reply-To: <1456268693-8630-3-git-send-email-han.xu@nxp.com> References: <1456268693-8630-1-git-send-email-han.xu@nxp.com> <1456268693-8630-3-git-send-email-han.xu@nxp.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Han, On Tue, 23 Feb 2016 17:04:50 -0600 Han Xu wrote: > add the clocks and clock-names in DT property, gpmi-io clock is > mandatory for all platforms, but some platforms, such as i.MX6Q may > need more extra clocks for submodules. More details please refer to the > SoC reference manual. > > Signed-off-by: Han Xu > --- > Documentation/devicetree/bindings/mtd/gpmi-nand.txt | 9 +++++++++ Please make sure you add the DT maintainers (and the DT ML) in Cc when you update DT bindings. Best Regards, Boris > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mtd/gpmi-nand.txt b/Documentation/devicetree/bindings/mtd/gpmi-nand.txt > index d02acaf..c8d0e2f 100644 > --- a/Documentation/devicetree/bindings/mtd/gpmi-nand.txt > +++ b/Documentation/devicetree/bindings/mtd/gpmi-nand.txt > @@ -13,6 +13,13 @@ Required properties: > and GPMI DMA channel ID. > Refer to dma.txt and fsl-mxs-dma.txt for details. > - dma-names: Must be "rx-tx". > + - clocks : The clocks needed by the gpmi controller. This field varies > + depends on the SoC design, "gpmi-io" is mandatory but some platforms may > + need several extra clocks, such as i.MX6Q, it requires "gpmi_apb, > + gpmi_bch, gpmi_bch_apb and per1_bch" for all submodules. Please refer to > + the HW design manual. > + - clock-names : the name of the clocks, please refer to the HW design > + manual. > > Optional properties: > - nand-on-flash-bbt: boolean to enable on flash bbt option if not > @@ -51,6 +58,8 @@ gpmi-nand@8000c000 { > interrupt-names = "bch"; > dmas = <&dma_apbh 4>; > dma-names = "rx-tx"; > + clocks = <&clks 50>,; > + clock-names = "gpmi_io"; > > partition@0 { > ... -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com