From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753417AbcD2Nac (ORCPT <rfc822;w@1wt.eu>);
	Fri, 29 Apr 2016 09:30:32 -0400
Received: from bhuna.collabora.co.uk ([46.235.227.227]:50428 "EHLO
	bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753147AbcD2Nab (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 29 Apr 2016 09:30:31 -0400
Date: Fri, 29 Apr 2016 10:30:23 -0300
From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
To: Hillf Danton <hillf.zj@alibaba-inc.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 01/13] staging/android: remove redundant comments on
 sync_merge_data
Message-ID: <20160429133023.GC2524@joana>
References: <00d201d1a1eb$86be73f0$943b5bd0$@alibaba-inc.com>
 <00d801d1a1ec$3f573a50$be05aef0$@alibaba-inc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <00d801d1a1ec$3f573a50$be05aef0$@alibaba-inc.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Hillf,

2016-04-29 Hillf Danton <hillf.zj@alibaba-inc.com>:

> > 
> > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > 
> > struct sync_merge_data already have documentation on top of the
> > struct definition. No need to duplicate it.
> > 
> > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > ---
> >  drivers/staging/android/uapi/sync.h | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/staging/android/uapi/sync.h b/drivers/staging/android/uapi/sync.h
> > index 7de5d6a..413303d 100644
> > --- a/drivers/staging/android/uapi/sync.h
> > +++ b/drivers/staging/android/uapi/sync.h
> > @@ -23,9 +23,9 @@
> >   * @pad:	padding for 64-bit alignment, should always be zero
> >   */
> >  struct sync_merge_data {
> > -	char	name[32]; /* name of new fence */
> > -	__s32	fd2; /* fd of second fence */
> > -	__s32	fence; /* fd on newly created fence */
> > +	char	name[32];
> > +	__s32	fd2;
> > +	__s32	fence;
> >  	__u32	flags;
> >  	__u32	pad;
> >  };
> > @@ -33,8 +33,8 @@ struct sync_merge_data {
> >  /**
> >   * struct sync_fence_info - detailed fence information
> >   * @obj_name:		name of parent sync_timeline
> > - * @driver_name:	name of driver implementing the parent
> > - * @status:		status of the fence 0:active 1:signaled <0:error
> > +* @driver_name:	name of driver implementing the parent
> > +* @status:		status of the fence 0:active 1:signaled <0:error
> 
> Would you please specify why this hunk is needed, with
> fence info not mentioned in commit message?

This shouldn't be here. Probably some leftover from a rebase that I
didn't notice. Thanks for pointing it out. I'll update this patch.

	Gustavo