From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753391AbcD2QXX (ORCPT ); Fri, 29 Apr 2016 12:23:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42798 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751339AbcD2QXW (ORCPT ); Fri, 29 Apr 2016 12:23:22 -0400 Date: Fri, 29 Apr 2016 11:23:20 -0500 From: Josh Poimboeuf To: Miroslav Benes Cc: jeyu@redhat.com, jikos@kernel.org, pmladek@suse.com, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] klp: make object/func-walking helpers more robust Message-ID: <20160429162320.swgc4emtok4euo3t@treble> References: <1461854048-31473-1-git-send-email-mbenes@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1461854048-31473-1-git-send-email-mbenes@suse.cz> User-Agent: Mutt/1.6.0.1 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 28, 2016 at 04:34:08PM +0200, Miroslav Benes wrote: > Current object-walking helper checks the presence of obj->funcs to > determine the end of objs array in klp_object structure. This is > somewhat fragile because one can easily forget about funcs definition > during livepatch creation. In such a case the livepatch module is > successfully loaded and all objects after the incorrect one are omitted. > This is very confusing. Let's make the helper more robust and check also > for the other external member, name. Thus the helper correctly stops on > an empty item of the array. We need to have a check for obj->funcs in > klp_init_object() to make it work. > > The same applies to a func-walking helper. > > As a benefit we'll check for new_func member definition during the > livepatch initialization. There is no such check anywhere in the code > now. > > Signed-off-by: Miroslav Benes Acked-by: Josh Poimboeuf -- Josh