From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752131AbcEAJnx (ORCPT ); Sun, 1 May 2016 05:43:53 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:40640 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751009AbcEAJnv (ORCPT ); Sun, 1 May 2016 05:43:51 -0400 Date: Sun, 1 May 2016 11:43:49 +0200 From: Pavel Machek To: Sebastian Reichel Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, Tony Lindgren , Aaro Koskinen , Ivaylo Dimitrov , Pali =?iso-8859-1?Q?Roh=E1r?= Subject: Re: [PATCH 5/6] HSI: omap_ssi: built omap_ssi and omap_ssi_port into one module Message-ID: <20160501094349.GE14243@amd> References: <1461982153-19139-1-git-send-email-sre@kernel.org> <1461982153-19139-6-git-send-email-sre@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461982153-19139-6-git-send-email-sre@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > Merge omap_ssi and omap_ssi_port into one module. This > fixes problems with module cycle dependencies introduced > by future patches. Interesting way of saying that this prepares us for future patch :-). > +++ b/drivers/hsi/controllers/Makefile > @@ -2,5 +2,5 @@ > # Makefile for HSI controllers drivers > # > > -obj-$(CONFIG_OMAP_SSI) += omap_ssi.o > -obj-$(CONFIG_OMAP_SSI_PORT) += omap_ssi_port.o > +omap_ssi-objs += omap_ssi_core.o omap_ssi_port.o > +obj-$(CONFIG_OMAP_SSI) += omap_ssi.o Can you simply do obj-$(CONFIG_OMAP_SSI) += omap_ssi_core.o omap_ssi_port.o instead? Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html