From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933916AbcECQGz (ORCPT ); Tue, 3 May 2016 12:06:55 -0400 Received: from mail.kernel.org ([198.145.29.136]:38571 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933338AbcECQGx (ORCPT ); Tue, 3 May 2016 12:06:53 -0400 Date: Tue, 3 May 2016 11:06:47 -0500 From: Rob Herring To: Philipp Zabel Cc: Akshay Bhat , airlied@linux.ie, steve_longerbeam@mentor.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] dt-bindings: imx: ldb: Add ddc-i2c-bus property Message-ID: <20160503160647.GA10680@rob-hp-laptop> References: <1461788614-7784-1-git-send-email-akshay.bhat@timesys.com> <1461788614-7784-2-git-send-email-akshay.bhat@timesys.com> <20160428214823.GA841@rob-hp-laptop> <1461915852.3521.3.camel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461915852.3521.3.camel@pengutronix.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 29, 2016 at 09:44:12AM +0200, Philipp Zabel wrote: > Am Donnerstag, den 28.04.2016, 16:48 -0500 schrieb Rob Herring: > > On Wed, Apr 27, 2016 at 04:23:34PM -0400, Akshay Bhat wrote: > > > Document the ddc-i2c-bus property used by imx-ldb driver to read EDID > > > information via I2C interface. > > > > > > Signed-off-by: Akshay Bhat > > > --- > > > > > > v3: > > > Newly added. > > > > > > Documentation/devicetree/bindings/display/imx/ldb.txt | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/Documentation/devicetree/bindings/display/imx/ldb.txt b/Documentation/devicetree/bindings/display/imx/ldb.txt > > > index 0a175d9..a407462 100644 > > > --- a/Documentation/devicetree/bindings/display/imx/ldb.txt > > > +++ b/Documentation/devicetree/bindings/display/imx/ldb.txt > > > @@ -62,6 +62,7 @@ Required properties: > > > display-timings are used instead. > > > > > > Optional properties (required if display-timings are used): > > > > The required part doesn't make sense if you add this, but... > > > > > + - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing > > > > Really, this should be part of a connector node since i2c goes from the > > i2c controller to a connector and is not part of the display controller. > > If the ddc i2c bus does indeed go through a connector, yes. Would that > warrant a generic "lvds-connector" binding for all those different types > of internal LVDS connectors? Probably an overkill for that case. It could be part of the panel node, but I'm reluctant to define a 3rd way. So this is fine as is. Acked-by: Rob Herring Rob