From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754682AbcEEN7W (ORCPT ); Thu, 5 May 2016 09:59:22 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:8718 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751890AbcEEN7U (ORCPT ); Thu, 5 May 2016 09:59:20 -0400 Date: Thu, 5 May 2016 09:58:44 -0400 From: Chris Mason To: Peter Zijlstra CC: Mike Galbraith , Ingo Molnar , Matt Fleming , Subject: Re: sched: tweak select_idle_sibling to look for idle threads Message-ID: <20160505135844.nfb5czbmgxlhyiw6@floor.thefacebook.com> Mail-Followup-To: Chris Mason , Peter Zijlstra , Mike Galbraith , Ingo Molnar , Matt Fleming , linux-kernel@vger.kernel.org References: <1462086753.9717.29.camel@suse.de> <20160502084615.GB3430@twins.programming.kicks-ass.net> <1462200604.3736.42.camel@suse.de> <20160502145817.GW3408@twins.programming.kicks-ass.net> <20160502154725.ckiewczbdubudyc7@floor.masoncoding.com> <20160503143225.GG3448@twins.programming.kicks-ass.net> <20160503151153.wp6jcnjadmw2ypmx@floor.masoncoding.com> <20160504154510.GH3448@twins.programming.kicks-ass.net> <20160504174616.k4xud2w232b6m4by@floor.masoncoding.com> <20160505093338.GK3448@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160505093338.GK3448@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.23.1 (2014-03-12) X-Originating-IP: [192.168.52.123] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-05-05_10:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 05, 2016 at 11:33:38AM +0200, Peter Zijlstra wrote: > On Wed, May 04, 2016 at 01:46:16PM -0400, Chris Mason wrote: > > It should, make sure you're at the top commit in git. > > > > git://git.kernel.org/pub/scm/linux/kernel/git/mason/schbench.git > > I did double check; I am on the top commit of that. I refetched and > rebuild just to make tripple sure. > > > It's not recent so I'd be surprised if you weren't already there. The > > default runtime is 30 seconds, but you can use -r to specify something > > shorter. > > > > It's possible I'm missing a wakeup to shut the whole thing down, but I > > thought I fixed that. > > Seems to still be missing, because: > > > ./schbench -p 4 -m 1 -t 1 > > Latency percentiles (usec) > > 50.0000th: 5 > > 75.0000th: 5 > > 90.0000th: 5 > > 95.0000th: 5 > > *99.0000th: 8 > > 99.5000th: 15 > > 99.9000th: 17 > > Over=0, min=0, max=652 > > avg worker transfer: 113768.27 ops/sec 444.41KB/s > > is not what mine does. I get ~25sec of cpu time and then it stalls > forever. > > I'll try and have a prod at the program itself if you have no pending > changes on your end. Sorry, I don't. Look at sleep_for_runtime() and how I test/set the global stopping variable in different places. I've almost certainly got someone waiting on a wakeup that'll never come. If all else fails, run_msg_thread() can pass a timeout to fwait() for a less error prone setup. I was just hoping to avoid the timers kernel side. -chris