From: Brian Norris <briannorris@chromium.org>
To: "Strashko, Grygorii" <grygorii.strashko@ti.com>
Cc: Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, Sekhar Nori <nsekhar@ti.com>,
David Fisher <david.fisher1@synopsys.com>,
Catalin Marinas <catalin.marinas@arm.com>,
"Thang Q. Nguyen" <tqnguyen@apm.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
linux-rockchip@lists.infradead.org, dianders@chromium.org,
wulf@rock-chips.com, Brian Norris <computersforpeace@gmail.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: usb: dwc3: host: inherit dma configuration from parent dev
Date: Thu, 5 May 2016 10:07:52 -0700 [thread overview]
Message-ID: <20160505170752.GA118697@google.com> (raw)
In-Reply-To: <1461612094-30939-1-git-send-email-grygorii.strashko@ti.com>
On Mon, Apr 25, 2016 at 10:21:34PM +0300, Strashko, Grygorii wrote:
> Now not all DMA paremters configured properly for "xhci-hcd" platform
> device which is created manually. For example: dma_pfn_offset, dam_ops
> and iommu configuration will not corresponds "dwc3" devices
> configuration. As result, this will cause problems like wrong DMA
> addresses translation on platforms with LPAE enabled like Keystone 2.
>
> When platform is using DT boot mode the DMA configuration will be
> parsed and applied from DT, so, to fix this issue, reuse
> of_dma_configure() API and retrieve DMA configuartion for "xhci-hcd"
> from DWC3 device node.
>
> Cc: David Fisher <david.fisher1@synopsys.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: "Thang Q. Nguyen" <tqnguyen@apm.com>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Tested-by: Brian Norris <briannorris@chromium.org>
What's the status of this? I see that there was some divergent
discussion about the merits of a dma_inherit() API...
FWIW, I'll reiterate Grygorii's note that Felipe's alternative patch
does NOT resolve the problem with the creation of the xhci-hcd platform
device:
https://patchwork.kernel.org/patch/8952721/
Brian
> ---
> drivers/usb/dwc3/host.c | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
> index c679f63..93c8ef9 100644
> --- a/drivers/usb/dwc3/host.c
> +++ b/drivers/usb/dwc3/host.c
> @@ -17,6 +17,7 @@
>
> #include <linux/platform_device.h>
> #include <linux/usb/xhci_pdriver.h>
> +#include <linux/of_device.h>
>
> #include "core.h"
>
> @@ -32,12 +33,7 @@ int dwc3_host_init(struct dwc3 *dwc)
> return -ENOMEM;
> }
>
> - dma_set_coherent_mask(&xhci->dev, dwc->dev->coherent_dma_mask);
> -
> xhci->dev.parent = dwc->dev;
> - xhci->dev.dma_mask = dwc->dev->dma_mask;
> - xhci->dev.dma_parms = dwc->dev->dma_parms;
> -
> dwc->xhci = xhci;
>
> ret = platform_device_add_resources(xhci, dwc->xhci_resources,
> @@ -62,6 +58,15 @@ int dwc3_host_init(struct dwc3 *dwc)
> phy_create_lookup(dwc->usb3_generic_phy, "usb3-phy",
> dev_name(&xhci->dev));
>
> + if (IS_ENABLED(CONFIG_OF) && dwc->dev->of_node) {
> + of_dma_configure(&xhci->dev, dwc->dev->of_node);
> + } else {
> + dma_set_coherent_mask(&xhci->dev, dwc->dev->coherent_dma_mask);
> +
> + xhci->dev.dma_mask = dwc->dev->dma_mask;
> + xhci->dev.dma_parms = dwc->dev->dma_parms;
> + }
> +
> ret = platform_device_add(xhci);
> if (ret) {
> dev_err(dwc->dev, "failed to register xHCI device\n");
prev parent reply other threads:[~2016-05-05 17:08 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 19:21 [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Grygorii Strashko
2016-04-26 6:17 ` Felipe Balbi
2016-04-26 8:14 ` Grygorii Strashko
2016-04-27 5:41 ` Felipe Balbi
2016-04-27 11:55 ` Grygorii Strashko
2016-04-27 13:59 ` Catalin Marinas
2016-04-27 14:11 ` Arnd Bergmann
2016-04-27 15:50 ` Catalin Marinas
2016-04-27 16:04 ` Arnd Bergmann
2016-04-27 16:53 ` Felipe Balbi
2016-04-27 17:42 ` Arnd Bergmann
2016-04-27 17:59 ` Alan Stern
2016-04-27 18:08 ` Arnd Bergmann
2016-04-27 20:05 ` Felipe Balbi
2016-04-27 21:05 ` Arnd Bergmann
2016-04-28 6:37 ` Felipe Balbi
2016-04-28 14:16 ` Russell King - ARM Linux
2016-04-28 14:23 ` Arnd Bergmann
2016-04-28 14:27 ` Felipe Balbi
2016-09-01 22:14 ` Leo Li
2016-09-02 10:43 ` Arnd Bergmann
2016-09-02 10:47 ` Russell King - ARM Linux
2016-09-02 11:08 ` Felipe Balbi
2016-09-02 14:11 ` Felipe Balbi
2016-09-02 14:21 ` Alan Stern
2016-09-02 15:51 ` Arnd Bergmann
2016-09-07 7:17 ` Roger Quadros
2016-09-07 8:29 ` Arnd Bergmann
2016-09-07 13:04 ` Roger Quadros
2016-09-07 14:38 ` Arnd Bergmann
2016-09-02 16:23 ` Grygorii Strashko
2016-09-02 10:53 ` Felipe Balbi
2016-09-02 11:55 ` Robin Murphy
2016-09-02 12:56 ` Felipe Balbi
2016-09-02 13:10 ` Arnd Bergmann
2016-09-02 22:16 ` Leo Li
2016-09-05 15:39 ` Arnd Bergmann
2016-09-06 6:35 ` Peter Chen
2016-09-06 6:40 ` Felipe Balbi
2016-09-06 10:46 ` Arnd Bergmann
2016-09-06 10:50 ` Felipe Balbi
2016-09-06 13:27 ` Arnd Bergmann
2016-09-07 6:51 ` Felipe Balbi
2016-09-07 7:44 ` Peter Chen
2016-09-07 8:52 ` Arnd Bergmann
2016-09-07 9:29 ` Peter Chen
2016-09-07 9:35 ` Russell King - ARM Linux
2016-09-07 10:18 ` Felipe Balbi
2016-09-06 10:38 ` Arnd Bergmann
2016-09-07 6:33 ` Peter Chen
2016-09-07 8:48 ` Arnd Bergmann
2016-09-07 9:55 ` Peter Chen
2016-09-07 10:33 ` Robin Murphy
2016-09-07 10:47 ` Felipe Balbi
2016-09-14 16:31 ` Lorenzo Pieralisi
2016-09-14 21:50 ` Arnd Bergmann
2016-09-07 10:24 ` Felipe Balbi
2016-09-07 15:24 ` Arnd Bergmann
2016-09-07 16:08 ` Alan Stern
2016-09-07 19:45 ` Arnd Bergmann
2016-09-08 1:15 ` Peter Chen
2016-09-08 8:02 ` Arnd Bergmann
2016-09-08 8:03 ` Felipe Balbi
2016-09-08 8:26 ` Arnd Bergmann
2016-09-08 8:29 ` Felipe Balbi
2016-09-08 8:45 ` Arnd Bergmann
2016-09-08 9:43 ` Felipe Balbi
2016-09-08 10:17 ` Arnd Bergmann
2016-09-08 11:00 ` Felipe Balbi
2016-09-08 11:11 ` Arnd Bergmann
2016-09-08 11:20 ` Felipe Balbi
2016-09-08 11:39 ` Arnd Bergmann
2016-09-08 11:52 ` Felipe Balbi
2016-09-08 12:46 ` Arnd Bergmann
2016-09-08 12:02 ` Grygorii Strashko
2016-09-08 12:14 ` Arnd Bergmann
2016-09-08 12:28 ` Peter Chen
2016-09-08 12:52 ` Arnd Bergmann
2016-09-09 1:37 ` Peter Chen
2016-09-08 12:59 ` Grygorii Strashko
2016-09-09 1:52 ` Peter Chen
2016-09-21 11:06 ` Sriram Dash
2016-09-21 11:31 ` Arnd Bergmann
2016-09-21 11:43 ` Sriram Dash
2016-09-21 12:48 ` Arnd Bergmann
2016-09-22 5:02 ` Sriram Dash
2016-10-07 22:46 ` Leo Li
2016-09-21 17:14 ` [PATCH] usb: xhci: Fix the patch inherit dma configuration from kbuild test robot
2016-04-27 20:57 ` [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Felipe Balbi
2016-04-27 14:14 ` Grygorii Strashko
2016-05-05 17:07 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160505170752.GA118697@google.com \
--to=briannorris@chromium.org \
--cc=arnd@arndb.de \
--cc=balbi@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=computersforpeace@gmail.com \
--cc=david.fisher1@synopsys.com \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=grygorii.strashko@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=tqnguyen@apm.com \
--cc=wulf@rock-chips.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).