From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758168AbcEFOIU (ORCPT ); Fri, 6 May 2016 10:08:20 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34364 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757430AbcEFOIS (ORCPT ); Fri, 6 May 2016 10:08:18 -0400 Date: Fri, 6 May 2016 16:08:16 +0200 From: Daniel Vetter To: Thierry Reding Cc: Noralf =?iso-8859-1?Q?Tr=F8nnes?= , treding@nvidia.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 4/4] drm/panel: Add helper for simple panel connector Message-ID: <20160506140816.GD27098@phenom.ffwll.local> Mail-Followup-To: Thierry Reding , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , treding@nvidia.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <1462454674-2246-1-git-send-email-noralf@tronnes.org> <1462454674-2246-5-git-send-email-noralf@tronnes.org> <20160506140347.GB4641@ulmo.ba.sec> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160506140347.GB4641@ulmo.ba.sec> X-Operating-System: Linux phenom 4.6.0-rc5+ User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 06, 2016 at 04:03:47PM +0200, Thierry Reding wrote: > On Thu, May 05, 2016 at 03:24:34PM +0200, Noralf Trønnes wrote: > > Add function to create a simple connector for a panel. > > I'm not sure I see the usefulness of this. Typically you'd attach a > panel to an encoder/connector, in which case you already have the > connector. > > Perhaps it would become more obvious why we need this if you posted > patches that show where this is used? The other helpers give you a simple drm pipeline with plane, crtc & encoder all baked into on drm_simple_pipeline structure. The only thing variable you have to hook up to that is the drm_connector. And I think for dead-simple panels avoiding the basic boilerplate in that does indeed make some sense. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch