From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752211AbcEIQRE (ORCPT ); Mon, 9 May 2016 12:17:04 -0400 Received: from 8bytes.org ([81.169.241.247]:55921 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751145AbcEIQRA (ORCPT ); Mon, 9 May 2016 12:17:00 -0400 Date: Mon, 9 May 2016 18:16:55 +0200 From: Joerg Roedel To: Wan Zongshun Cc: Wan Zongshun , iommu@lists.linux-foundation.org, mcuos.com@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/amd: Set AMD iommu callbacks for platform bus driver Message-ID: <20160509161655.GF13971@8bytes.org> References: <1460640533-3025-1-git-send-email-vincent.wan@amd.com> <20160509102041.GA13275@8bytes.org> <8c4cc9fc-26df-759e-6630-7bab927cf01b@iommu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8c4cc9fc-26df-759e-6630-7bab927cf01b@iommu.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 09, 2016 at 08:17:12PM +0800, Wan Zongshun wrote: > Currently, Only New eMMC driver will rely on this sdhci-acpi.c, but > I could not find a suitable ifdef XXX micro to limit this > platform_bus_type here like AMBA bus type before. > > Do you think this MMC_SDHCI_ACPI is ok? Okay, looks like platform_bus_type does not depend on any config-symbol. So the patch is fine, but please add a comment why the iommu-ops are needed on the platform bus. Joerg