From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751936AbcEJFEX (ORCPT ); Tue, 10 May 2016 01:04:23 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:36987 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751190AbcEJFEV (ORCPT ); Tue, 10 May 2016 01:04:21 -0400 Date: Tue, 10 May 2016 01:04:18 -0400 (EDT) Message-Id: <20160510.010418.1148844422449581387.davem@davemloft.net> To: arnd@arndb.de Cc: pablo@netfilter.org, kaber@trash.net, kadlec@blackhole.kfki.hu, fw@strlen.de, daniel@iogearbox.net, sasha.levin@oracle.com, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: conntrack: remove uninitialized shadow variable From: David Miller In-Reply-To: <1462823254-3137116-1-git-send-email-arnd@arndb.de> References: <1462823254-3137116-1-git-send-email-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 09 May 2016 22:04:20 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Mon, 9 May 2016 21:47:23 +0200 > A recent commit introduced an unconditional use of an uninitialized > variable, as reported in this gcc warning: > > net/netfilter/nf_conntrack_core.c: In function '__nf_conntrack_confirm': > net/netfilter/nf_conntrack_core.c:632:33: error: 'ctinfo' may be used uninitialized in this function [-Werror=maybe-uninitialized] > bytes = atomic64_read(&counter[CTINFO2DIR(ctinfo)].bytes); > ^ > net/netfilter/nf_conntrack_core.c:628:26: note: 'ctinfo' was declared here > enum ip_conntrack_info ctinfo; > > The problem is that a local variable shadows the function parameter. > This removes the local variable, which looks like what Pablo originally > intended. > > Signed-off-by: Arnd Bergmann > Fixes: 71d8c47fc653 ("netfilter: conntrack: introduce clash resolution on insertion race") Applied.