From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752800AbcEJOQs (ORCPT ); Tue, 10 May 2016 10:16:48 -0400 Received: from mx2.suse.de ([195.135.220.15]:49130 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751448AbcEJOQo (ORCPT ); Tue, 10 May 2016 10:16:44 -0400 Date: Tue, 10 May 2016 16:16:41 +0200 From: Jan Kara To: Vishal Verma Cc: linux-nvdimm@ml01.01.org, Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, xfs@oss.sgi.com, linux-ext4@vger.kernel.org, linux-mm@kvack.org, Ross Zwisler , Dan Williams , Dave Chinner , Jan Kara , Jens Axboe , Andrew Morton , linux-kernel@vger.kernel.org, Christoph Hellwig , Jeff Moyer , Boaz Harrosh Subject: Re: [PATCH v5 3/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors Message-ID: <20160510141641.GM11897@quack2.suse.cz> References: <1462571591-3361-1-git-send-email-vishal.l.verma@intel.com> <1462571591-3361-4-git-send-email-vishal.l.verma@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462571591-3361-4-git-send-email-vishal.l.verma@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 06-05-16 15:53:09, Vishal Verma wrote: > From: Matthew Wilcox > > dax_clear_sectors() cannot handle poisoned blocks. These must be > zeroed using the BIO interface instead. Convert ext2 and XFS to use > only sb_issue_zerout(). > > Signed-off-by: Matthew Wilcox > [vishal: Also remove the dax_clear_sectors function entirely] > Signed-off-by: Vishal Verma The patch looks good. You can add: Reviewed-by: Jan Kara Honza -- Jan Kara SUSE Labs, CR