From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752687AbcEJPpX (ORCPT ); Tue, 10 May 2016 11:45:23 -0400 Received: from mx2.suse.de ([195.135.220.15]:55657 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751409AbcEJPpR (ORCPT ); Tue, 10 May 2016 11:45:17 -0400 Date: Tue, 10 May 2016 17:45:17 +0200 From: Michal Marek To: Christopher Covington Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Azriel Samson , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Timur Tabi Subject: Re: [PATCH v1] builddeb: fix missing headers in linux-headers package Message-ID: <20160510154516.GF13314@pobox.suse.cz> References: <1459445479-10948-1-git-send-email-asamson@codeaurora.org> <572B5BC4.7080402@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <572B5BC4.7080402@codeaurora.org> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 05, 2016 at 10:42:12AM -0400, Christopher Covington wrote: > On 03/31/2016 01:31 PM, Azriel Samson wrote: > > The kernel headers package (linux-headers) doesn't include > > header files from other architectures required to build > > out-of-tree modules. > > > > For e.g. on ARM64, opcodes.h includes the same file from ARM > > which causes the following error: > > ./arch/arm64/include/asm/opcodes.h:1:43: fatal error: > > ../../arm/include/asm/opcodes.h: No such file or directory > > compilation terminated. > > > > Signed-off-by: Azriel Samson > > --- > > scripts/package/builddeb | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/scripts/package/builddeb b/scripts/package/builddeb > > index 6c3b038..06ba0d9 100755 > > --- a/scripts/package/builddeb > > +++ b/scripts/package/builddeb > > @@ -322,7 +322,7 @@ fi > > > > # Build kernel header package > > (cd $srctree; find . -name Makefile\* -o -name Kconfig\* -o -name \*.pl) > "$objtree/debian/hdrsrcfiles" > > -(cd $srctree; find arch/$SRCARCH/include include scripts -type f) >> "$objtree/debian/hdrsrcfiles" > > +(cd $srctree; find arch/*/include include scripts -type f) >> "$objtree/debian/hdrsrcfiles" > > (cd $srctree; find arch/$SRCARCH -name module.lds -o -name Kbuild.platforms -o -name Platform) >> "$objtree/debian/hdrsrcfiles" > > (cd $srctree; find $(find arch/$SRCARCH -name include -o -name scripts -type d) -type f) >> "$objtree/debian/hdrsrcfiles" > > (cd $objtree; find arch/$SRCARCH/include Module.symvers include scripts -type f) >> "$objtree/debian/hdrobjfiles" > > Any feedback on this? Michal, do you think this would be appropriate to > include in 4.7? Applied to kbuild.git#misc now. Michal