linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
	linux-input@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Bastien Nocera <hadess@hadess.net>,
	Alexandre Courbot <acourbot@nvidia.com>,
	Lejun Zhu <lejun.zhu@linux.intel.com>
Subject: Re: [PATCH 1/3] Input - soc_button_array: use gpio_is_valid()
Date: Tue, 10 May 2016 18:33:10 +0200	[thread overview]
Message-ID: <20160510163310.GQ23234@mail.corp.redhat.com> (raw)
In-Reply-To: <CAOMZO5Avvy1BicUD-SwvUofpLtcEVyZHoceXSibq9wd1i7fX5A@mail.gmail.com>

On May 10 2016 or thereabouts, Fabio Estevam wrote:
> On Tue, May 10, 2016 at 12:37 PM, Benjamin Tissoires
> <benjamin.tissoires@redhat.com> wrote:
> 
> > @@ -92,7 +93,7 @@ soc_button_device_create(struct platform_device *pdev,
> >                         continue;
> >
> >                 gpio = soc_button_lookup_gpio(&pdev->dev, info->acpi_index);
> > -               if (gpio < 0)
> > +               if (gpio_is_valid(gpio))
> 
> Shouldn't it be "if (!gpio_is_valid(gpio))" ?

Oops, indeed. I messed up between the various trees as it's not that
convenient to recompile a full kernel on an atom device. Will fix this
in v2.

Cheers,
Benjamin

  reply	other threads:[~2016-05-10 16:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-10 15:37 [PATCH 0/3] Input: soc_button_array fixes and question Benjamin Tissoires
2016-05-10 15:37 ` [PATCH 1/3] Input - soc_button_array: use gpio_is_valid() Benjamin Tissoires
2016-05-10 15:56   ` Fabio Estevam
2016-05-10 16:33     ` Benjamin Tissoires [this message]
2016-05-10 15:37 ` [PATCH 2/3] Input - soc_button_array: bail out earlier if gpiod_count is null Benjamin Tissoires
2016-05-10 15:37 ` [PATCH 3/3] Input - soc_button_array: make sure one GPIO is not assigned twice Benjamin Tissoires
2016-05-13 15:57 ` [PATCH 0/3] Input: soc_button_array fixes and question Benjamin Tissoires

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160510163310.GQ23234@mail.corp.redhat.com \
    --to=benjamin.tissoires@redhat.com \
    --cc=acourbot@nvidia.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=festevam@gmail.com \
    --cc=hadess@hadess.net \
    --cc=lejun.zhu@linux.intel.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yongjun_wei@trendmicro.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).