From: Matt Fleming <matt@codeblueprint.co.uk>
To: "Compostella, Jeremy" <jeremy.compostella@intel.com>
Cc: "Elliott, Robert (Persistent Memory)" <elliott@hpe.com>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H . Peter Anvin" <hpa@zytor.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 2/5] efibc: Fix excessive stack footprint warning
Date: Wed, 11 May 2016 13:43:38 +0100 [thread overview]
Message-ID: <20160511124338.GW2839@codeblueprint.co.uk> (raw)
In-Reply-To: <87r3dauwzt.fsf@intel.com>
On Tue, 10 May, at 10:40:22AM, Jeremy Compostella wrote:
> Why not. See patch as attachment.
>
> Thanks,
>
> Jérémy
>
> From 8a9b07e2d7242fa8a36157f1025202a96c3c7c9a Mon Sep 17 00:00:00 2001
> From: Jeremy Compostella <jeremy.compostella@intel.com>
> Date: Tue, 10 May 2016 10:34:21 +0200
> Subject: [PATCH] efibc: report the EFI variable name in the error messages
>
> Report the name of the EFI variable if the value is incorrect or if
> efibc_set_variable() fails to allocate the struct efivar_entry object.
>
> Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com>
> ---
> drivers/firmware/efi/efibc.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/efi/efibc.c b/drivers/firmware/efi/efibc.c
> index cb4f573..93d34a1 100644
> --- a/drivers/firmware/efi/efibc.c
> +++ b/drivers/firmware/efi/efibc.c
> @@ -37,13 +37,14 @@ static int efibc_set_variable(const char *name, const char *value)
> size_t size = (strlen(value) + 1) * sizeof(efi_char16_t);
>
> if (size > sizeof(entry->var.Data)) {
> - pr_err("value is too large");
> + pr_err("value is too large for %s EFI variable", name);
> return -EINVAL;
> }
It'd be a good idea to print 'size' too.
>
> entry = kmalloc(sizeof(*entry), GFP_KERNEL);
> if (!entry) {
> - pr_err("failed to allocate efivar entry");
> + pr_err("failed to allocate efivar entry for %s EFI variable",
> + name);
> return -ENOMEM;
> }
Aren't these pr_err() calls missing newline characters?
next prev parent reply other threads:[~2016-05-11 12:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 21:39 [GIT PULL 0/5] EFI changes for v4.7 Matt Fleming
2016-05-06 21:39 ` [PATCH 1/5] efi/capsule: Make efi_capsule_pending() lockless Matt Fleming
2016-05-07 6:33 ` [tip:efi/core] " tip-bot for Matt Fleming
2016-05-06 21:39 ` [PATCH 2/5] efibc: Fix excessive stack footprint warning Matt Fleming
2016-05-07 6:34 ` [tip:efi/core] " tip-bot for Jeremy Compostella
2016-05-09 23:41 ` [PATCH 2/5] " Elliott, Robert (Persistent Memory)
2016-05-10 8:40 ` Compostella, Jeremy
2016-05-11 12:43 ` Matt Fleming [this message]
2016-05-11 15:16 ` Compostella, Jeremy
2016-05-14 19:20 ` Matt Fleming
2016-05-06 21:39 ` [PATCH 3/5] efi/capsule: Move 'capsule' to the stack in efi_capsule_supported() Matt Fleming
2016-05-07 6:34 ` [tip:efi/core] " tip-bot for Matt Fleming
2016-05-06 21:39 ` [PATCH 4/5] efi: Merge boolean flag arguments Matt Fleming
2016-05-07 6:34 ` [tip:efi/core] " tip-bot for Julia Lawall
2016-05-06 21:39 ` [PATCH 5/5] efivarfs: Make efivarfs_file_ioctl static Matt Fleming
2016-05-07 6:35 ` [tip:efi/core] efivarfs: Make efivarfs_file_ioctl() static tip-bot for Peter Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160511124338.GW2839@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=elliott@hpe.com \
--cc=hpa@zytor.com \
--cc=jeremy.compostella@intel.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).