From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932512AbcEKNXm (ORCPT ); Wed, 11 May 2016 09:23:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47321 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932204AbcEKNXj (ORCPT ); Wed, 11 May 2016 09:23:39 -0400 Date: Wed, 11 May 2016 15:23:36 +0200 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, peterz@infradead.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 03/10] x86, perf: Add Top Down events to Intel Core Message-ID: <20160511132336.GA30427@krava> References: <1462489447-31832-1-git-send-email-andi@firstfloor.org> <1462489447-31832-4-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462489447-31832-4-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 11 May 2016 13:23:39 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 05, 2016 at 04:04:00PM -0700, Andi Kleen wrote: SNIP > + > +EVENT_ATTR_STR_HT(topdown-total-slots, td_total_slots, > + "event=0x3c,umask=0x0", /* cpu_clk_unhalted.thread */ > + "event=0x3c,umask=0x0,any=1"); /* cpu_clk_unhalted.thread_any */ > +EVENT_ATTR_STR_HT(topdown-total-slots.scale, td_total_slots_scale, "4", "2"); > +EVENT_ATTR_STR(topdown-slots-issued, td_slots_issued, > + "event=0xe,umask=0x1"); /* uops_issued.any */ > +EVENT_ATTR_STR(topdown-slots-retired, td_slots_retired, > + "event=0xc2,umask=0x2"); /* uops_retired.retire_slots */ > +EVENT_ATTR_STR(topdown-fetch-bubbles, td_fetch_bubbles, > + "event=0x9c,umask=0x1"); /* idq_uops_not_delivered_core */ > +EVENT_ATTR_STR_HT(topdown-recovery-bubbles, td_recovery_bubbles, > + "event=0xd,umask=0x3,cmask=1", /* int_misc.recovery_cycles */ > + "event=0xd,umask=0x3,cmask=1,any=1"); /* int_misc.recovery_cycles_any */ > +EVENT_ATTR_STR_HT(topdown-recovery-bubbles.scale, td_recovery_bubbles_scale, > + "4", "2"); > + > struct attribute *snb_events_attrs[] = { > EVENT_PTR(mem_ld_snb), > EVENT_PTR(mem_st_snb), > + EVENT_PTR(td_slots_issued), > + EVENT_PTR(td_slots_retired), > + EVENT_PTR(td_fetch_bubbles), > + EVENT_PTR(td_total_slots), > + EVENT_PTR(td_total_slots_scale), > + EVENT_PTR(td_recovery_bubbles), > + EVENT_PTR(td_recovery_bubbles_scale), Peter, Ingo, any thoughts about adding these events? The rest of the tooling code is based on them being accepted.. thanks, jirka