From: Stephen Boyd <sboyd@codeaurora.org>
To: Priit Laes <plaes@plaes.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
Mike Turquette <mturquette@baylibre.com>,
David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh+dt@kernel.org>, Daniel Vetter <daniel@ffwll.ch>,
Hans de Goede <hdegoede@redhat.com>,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
dri-devel@lists.freedesktop.org,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Alexander Kaplan <alex@nextthing.co>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [linux-sunxi] Re: [PATCH v4 01/11] clk: sunxi: Add display and TCON0 clocks driver
Date: Wed, 11 May 2016 15:15:41 -0700 [thread overview]
Message-ID: <20160511221541.GG3492@codeaurora.org> (raw)
In-Reply-To: <1462907459.9981.0.camel@plaes.org>
On 05/10, Priit Laes wrote:
> On Mon, 2016-05-09 at 15:39 -0700, Stephen Boyd wrote:
> > On 05/09, Stephen Boyd wrote:
> > >
> > >
> > > Ok I applied this one to clk-next.
> > >
> > And I squashed this in to silence the following checker warning.
> >
> > drivers/clk/sunxi/clk-sun4i-display.c:110:33: warning: Variable
> > length array is used.
> >
> > ---8<---
> > diff --git a/drivers/clk/sunxi/clk-sun4i-display.c
> > b/drivers/clk/sunxi/clk-sun4i-display.c
> > index f02e250e64ed..f8ff6c4a5633 100644
> > --- a/drivers/clk/sunxi/clk-sun4i-display.c
> > +++ b/drivers/clk/sunxi/clk-sun4i-display.c
> > @@ -107,7 +107,7 @@ static int sun4i_a10_display_reset_xlate(struct
> > reset_controller_dev *rcdev,
> > static void __init sun4i_a10_display_init(struct device_node *node,
> > const struct
> > sun4i_a10_display_clk_data *data)
> > {
> > - const char *parents[data->parents];
> > + const char *parents[4];
>
> This change breaks at least de_[bf]e clocks which have 3 clock parents.
>
I just used the largest data->parents number, which was 4. How
does that break anything?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-05-11 22:15 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 13:22 [PATCH v4 00/11] drm: Add Allwinner A10 display engine support Maxime Ripard
2016-04-25 13:22 ` [PATCH v4 01/11] clk: sunxi: Add display and TCON0 clocks driver Maxime Ripard
2016-05-06 22:30 ` Stephen Boyd
2016-05-08 20:03 ` Maxime Ripard
2016-05-09 22:32 ` Stephen Boyd
2016-05-09 22:39 ` Stephen Boyd
2016-05-10 6:36 ` Maxime Ripard
2016-05-11 22:13 ` Stephen Boyd
2016-05-10 19:10 ` [linux-sunxi] " Priit Laes
2016-05-11 22:15 ` Stephen Boyd [this message]
2016-05-12 3:39 ` Priit Laes
2016-05-12 6:59 ` Maxime Ripard
2016-05-12 8:30 ` Maxime Ripard
2016-05-12 21:47 ` Stephen Boyd
2016-04-25 13:22 ` [PATCH v4 02/11] ARM: sun5i: a13: Add display and TCON clocks Maxime Ripard
2016-04-25 13:22 ` [PATCH v4 03/11] drm: fb: Add seq_file definition Maxime Ripard
2016-04-25 13:22 ` [PATCH v4 04/11] drm: sun4i: Add DT bindings documentation Maxime Ripard
2016-04-28 2:37 ` Rob Herring
2016-04-25 13:22 ` [PATCH v4 05/11] drm: Add Allwinner A10 Display Engine support Maxime Ripard
2016-04-26 9:14 ` Boris Brezillon
2016-04-28 7:40 ` Maxime Ripard
2016-04-25 13:22 ` [PATCH v4 06/11] drm: sun4i: Add RGB output Maxime Ripard
2016-04-26 9:56 ` Boris Brezillon
2016-04-25 13:22 ` [PATCH v4 07/11] drm: sun4i: Add composite output Maxime Ripard
2016-04-26 9:59 ` Boris Brezillon
2016-04-25 13:22 ` [PATCH v4 08/11] drm: sun4i: tv: Add PAL output standard Maxime Ripard
2016-04-26 9:59 ` Boris Brezillon
2016-04-25 13:22 ` [PATCH v4 09/11] drm: sun4i: tv: Add NTSC " Maxime Ripard
2016-04-26 9:59 ` Boris Brezillon
2016-04-25 13:22 ` [PATCH v4 10/11] ARM: sun5i: r8: Add display blocks to the DTSI Maxime Ripard
2016-04-25 13:22 ` [PATCH v4 11/11] ARM: sun5i: chip: Enable the TV Encoder Maxime Ripard
2016-04-25 15:56 ` [PATCH v4 00/11] drm: Add Allwinner A10 display engine support Emil Velikov
2016-05-04 18:01 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160511221541.GG3492@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=airlied@linux.ie \
--cc=alex@nextthing.co \
--cc=boris.brezillon@free-electrons.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=mturquette@baylibre.com \
--cc=plaes@plaes.org \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).