From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752434AbcELHDz (ORCPT ); Thu, 12 May 2016 03:03:55 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:38592 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751943AbcELHDx (ORCPT ); Thu, 12 May 2016 03:03:53 -0400 Date: Thu, 12 May 2016 00:03:52 -0700 From: Christoph Hellwig To: Johannes Thumshirn Cc: Keith Busch , Jens Axboe , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org Subject: Re: [PATCH] NVMe: Only release requested regions Message-ID: <20160512070352.GB20802@infradead.org> References: <1462886068-14605-1-git-send-email-jthumshirn@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462886068-14605-1-git-send-email-jthumshirn@suse.de> User-Agent: Mutt/1.5.24 (2015-08-30) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > static void nvme_dev_unmap(struct nvme_dev *dev) > { > + struct pci_dev *pdev = to_pci_dev(dev->dev); > + int bars; > + > if (dev->bar) > iounmap(dev->bar); > - pci_release_regions(to_pci_dev(dev->dev)); > + > + bars = pci_select_bars(pdev, IORESOURCE_MEM); > + pci_release_selected_regions(pdev, bars); This looks fine, but I really hate this API. Can someone add these two nice helpers to pci.h: static inline int pci_request_mem_regions(struct pci_dev *pdev, const char *name) { return pci_request_selected_regions(pdev, pci_select_bars(pdev, IORESOURCE_MEM), name); } static inline void pci_release_mem_regions(struct pci_dev *pdev) { return pci_release_selected_regions(pdev, pci_select_bars(pdev, IORESOURCE_MEM)); } But for now this should do it: Reviewed-by: Christoph Hellwig