From: Rich Felker <dalias@libc.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: robh+dt@kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, arnd@arndb.de,
shawnguo@kernel.org, catalin.marinas@arm.com,
grant.likely@linaro.org, olof@lixom.net, linux@arm.linux.org.uk,
yamada.masahiro@socionext.com, guohanjun@huawei.com,
Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: Re: [PATCH v4 10/18] sh: Remove unnecessary of_platform_populate with default match table
Date: Thu, 12 May 2016 14:38:22 -0400 [thread overview]
Message-ID: <20160512183822.GL21636@brightrain.aerifal.cx> (raw)
In-Reply-To: <1463054775-18170-11-git-send-email-wangkefeng.wang@huawei.com>
On Thu, May 12, 2016 at 08:06:07PM +0800, Kefeng Wang wrote:
> After patch "of/platform: Add common method to populate default bus",
> it is possible for arch code to remove unnecessary callers about the
> of_platform_populate with default match table.
s/about the/of/ ?
> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
> Cc: Rich Felker <dalias@libc.org>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> arch/sh/boards/of-generic.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/arch/sh/boards/of-generic.c b/arch/sh/boards/of-generic.c
> index b4d4313..911ffb9 100644
> --- a/arch/sh/boards/of-generic.c
> +++ b/arch/sh/boards/of-generic.c
> @@ -9,7 +9,6 @@
> */
>
> #include <linux/of.h>
> -#include <linux/of_platform.h>
> #include <linux/of_fdt.h>
> #include <linux/clocksource.h>
> #include <linux/irqchip.h>
> @@ -179,16 +178,3 @@ void __init arch_init_clk_ops(struct sh_clk_ops **ops, int idx)
> void __init plat_irq_setup(void)
> {
> }
> -
> -static int __init sh_of_device_init(void)
> -{
> - pr_info("SH generic board support: populating platform devices\n");
> - if (of_have_populated_dt()) {
> - of_platform_populate(NULL, of_default_bus_match_table,
> - NULL, NULL);
> - } else {
> - pr_crit("Device tree not populated\n");
> - }
> - return 0;
> -}
> -arch_initcall_sync(sh_of_device_init);
> --
> 1.7.12.4
I have not tested this, but as long as the new arch-generic code takes
place at the same point in the init sequence (arch_initcall_sync), as
it seems to, I don't expect any sh-specific breakage. In general I'm
happy to see this kind of change.
Rich
next prev parent reply other threads:[~2016-05-12 18:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 12:05 [PATCH v4 00/18] Cleanup for populate default bus Kefeng Wang
2016-05-12 12:05 ` [PATCH v4 01/18] of/platform: Add common method to " Kefeng Wang
2016-05-25 14:46 ` Rob Herring
2016-05-26 7:43 ` Kefeng Wang
2016-05-12 12:05 ` [PATCH v4 02/18] arc: Remove unnecessary of_platform_populate with default match table Kefeng Wang
2016-05-13 3:03 ` Vineet Gupta
2016-05-12 12:06 ` [PATCH v4 03/18] arm: " Kefeng Wang
2016-05-13 2:58 ` Viresh Kumar
2016-05-12 12:06 ` [PATCH v4 04/18] arm64: " Kefeng Wang
2016-05-12 12:06 ` [PATCH v4 05/18] c6x: " Kefeng Wang
2016-05-12 12:06 ` [PATCH v4 06/18] cris: " Kefeng Wang
2016-05-16 8:00 ` Jesper Nilsson
2016-05-12 12:06 ` [PATCH v4 07/18] metag: " Kefeng Wang
2016-05-12 12:06 ` [PATCH v4 08/18] mips: " Kefeng Wang
2016-05-12 12:06 ` [PATCH v4 09/18] nios2: " Kefeng Wang
2016-05-12 12:06 ` [PATCH v4 10/18] sh: " Kefeng Wang
2016-05-12 18:38 ` Rich Felker [this message]
2016-05-13 1:44 ` Kefeng Wang
2016-05-12 12:06 ` [PATCH v4 11/18] xtensa: " Kefeng Wang
2016-05-12 12:06 ` [PATCH v4 12/18] arm: use of_platform_default_populate() to populate Kefeng Wang
2016-05-13 2:59 ` Viresh Kumar
2016-05-17 7:59 ` Sekhar Nori
2016-05-17 9:14 ` Nicolas Ferre
2016-05-12 12:06 ` [PATCH v4 13/18] mips: use of_platform_default_populate() to populate default bus Kefeng Wang
2016-05-12 12:06 ` [PATCH v4 14/18] bus: imx-weim: " Kefeng Wang
2016-05-12 12:06 ` [PATCH v4 15/18] bus: uniphier-system-bus: " Kefeng Wang
2016-05-12 12:06 ` [PATCH v4 16/18] memory: omap-gpmc: " Kefeng Wang
2016-05-12 12:06 ` [PATCH v4 17/18] of: unittest: " Kefeng Wang
2016-05-12 12:06 ` [PATCH v4 18/18] Revert "of/platform: export of_default_bus_match_table" Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160512183822.GL21636@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=grant.likely@linaro.org \
--cc=guohanjun@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=wangkefeng.wang@huawei.com \
--cc=yamada.masahiro@socionext.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).